Skip to content

Commit

Permalink
Fixed pylint warnings for PathDressupDogbone
Browse files Browse the repository at this point in the history
  • Loading branch information
@mlampert
mlampert committed Jul 1, 2019
1 parent c17989f commit 8769618
Showing 1 changed file with 67 additions and 34 deletions.
101 changes: 67 additions & 34 deletions src/Mod/Path/PathScripts/PathDressupDogbone.py
View file
Expand Up @@ -35,8 +35,6 @@

from PySide import QtCore

"""Dogbone Dressup object and FreeCAD command"""

LOG_MODULE = PathLog.thisModule()

LOGLEVEL = False
Expand Down Expand Up @@ -146,6 +144,8 @@ def edgesForCommands(cmds, startPt):


class Style:
# pylint: disable=no-init

Dogbone = 'Dogbone'
Tbone_H = 'T-bone horizontal'
Tbone_V = 'T-bone vertical'
Expand All @@ -155,6 +155,8 @@ class Style:


class Side:
# pylint: disable=no-init

Left = 'Left'
Right = 'Right'
All = [Left, Right]
Expand All @@ -169,13 +171,17 @@ def oppositeOf(cls, side):


class Incision:
# pylint: disable=no-init

Fixed = 'fixed'
Adaptive = 'adaptive'
Custom = 'custom'
All = [Adaptive, Fixed, Custom]


class Smooth:
# pylint: disable=no-init

Neither = 0
In = 1
Out = 2
Expand All @@ -192,6 +198,7 @@ class Smooth:
# Instances of Chord are generally considered immutable and all movement member
# functions return new instances.
class Chord (object):

def __init__(self, start=None, end=None):
if not start:
start = FreeCAD.Vector()
Expand Down Expand Up @@ -294,9 +301,9 @@ def isAPlungeMove(self):
return not PathGeom.isRoughly(self.End.z, self.Start.z)

def foldsBackOrTurns(self, chord, side):
dir = chord.getDirectionOf(self)
PathLog.info(" - direction = %s/%s" % (dir, side))
return dir == 'Back' or dir == side
direction = chord.getDirectionOf(self)
PathLog.info(" - direction = %s/%s" % (direction, side))
return direction == 'Back' or direction == side

def connectsTo(self, chord):
return PathGeom.pointsCoincide(self.End, chord.Start)
Expand All @@ -313,64 +320,74 @@ def __init__(self, boneId, obj, lastCommand, inChord, outChord, smooth, F):
self.smooth = Smooth.Neither
self.F = F

# initialized later
self.cDist = None
self.cAngle = None
self.tAngle = None
self.cPt = None

def angle(self):
if not hasattr(self, 'cAngle'):
if self.cAngle is None:
baseAngle = self.inChord.getAngleXY()
turnAngle = self.outChord.getAngle(self.inChord)
angle = addAngle(baseAngle, (turnAngle - math.pi)/2)
theta = addAngle(baseAngle, (turnAngle - math.pi)/2)
if self.obj.Side == Side.Left:
angle = addAngle(angle, math.pi)
theta = addAngle(theta, math.pi)
self.tAngle = turnAngle
self.cAngle = angle
self.cAngle = theta
return self.cAngle

def distance(self, toolRadius):
if not hasattr(self, 'cDist'):
if self.cDist is None:
self.angle() # make sure the angles are initialized
self.cDist = toolRadius / math.cos(self.tAngle/2)
return self.cDist

def corner(self, toolRadius):
if not hasattr(self, 'cPt'):
if self.cPt is None:
self.cPt = self.inChord.move(self.distance(toolRadius), self.angle()).End
return self.cPt

def location(self):
return (self.inChord.End.x, self.inChord.End.y)

def adaptiveLength(self, boneAngle, toolRadius):
angle = self.angle()
theta = self.angle()
distance = self.distance(toolRadius)
# there is something weird happening if the boneAngle came from a horizontal/vertical t-bone
# for some reason pi/2 is not equal to pi/2
if math.fabs(angle - boneAngle) < 0.00001:
if math.fabs(theta - boneAngle) < 0.00001:
# moving directly towards the corner
PathLog.debug("adaptive - on target: %.2f - %.2f" % (distance, toolRadius))
return distance - toolRadius
PathLog.debug("adaptive - angles: corner=%.2f bone=%.2f diff=%.12f" % (angle/math.pi, boneAngle/math.pi, angle - boneAngle))
PathLog.debug("adaptive - angles: corner=%.2f bone=%.2f diff=%.12f" % (theta/math.pi, boneAngle/math.pi, theta - boneAngle))

# The bones root and end point form a triangle with the intersection of the tool path
# with the toolRadius circle around the bone end point.
# In case the math looks questionable, look for "triangle ssa"
# c = distance
# b = self.toolRadius
# beta = fabs(boneAngle - angle)
beta = math.fabs(addAngle(boneAngle, -angle))
# beta = fabs(boneAngle - theta)
beta = math.fabs(addAngle(boneAngle, -theta)) # pylint: disable=invalid-unary-operand-type
D = (distance / toolRadius) * math.sin(beta)
if D > 1: # no intersection
PathLog.debug("adaptive - no intersection - no bone")
return 0
gamma = math.asin(D)
alpha = math.pi - beta - gamma
length = toolRadius * math.sin(alpha) / math.sin(beta)
if D < 1 and toolRadius < distance: # there exists a second solution
beta2 = beta
gamma2 = math.pi - gamma
alpha2 = math.pi - beta2 - gamma2
length2 = toolRadius * math.sin(alpha2) / math.sin(beta2)
length = min(length, length2)

PathLog.debug("adaptive corner=%.2f * %.2f˚ -> bone=%.2f * %.2f˚" % (distance, angle, length, boneAngle))
if PathGeom.isRoughly(0.0, math.sin(beta)):
# it is not a good idea to divide by 0
length = 0.0
else:
length = toolRadius * math.sin(alpha) / math.sin(beta)
if D < 1 and toolRadius < distance: # there exists a second solution
beta2 = beta
gamma2 = math.pi - gamma
alpha2 = math.pi - beta2 - gamma2
length2 = toolRadius * math.sin(alpha2) / math.sin(beta2)
length = min(length, length2)

PathLog.debug("adaptive corner=%.2f * %.2f˚ -> bone=%.2f * %.2f˚" % (distance, theta, length, boneAngle))
return length


Expand All @@ -396,6 +413,15 @@ def __init__(self, obj, base):
obj.Proxy = self
obj.Base = base

# initialized later
self.boneShapes = None
self.toolRadius = None
self.dbg = None
self.locationBlacklist = None
self.shapes = None
self.boneId = None
self.bones = None

def onDocumentRestored(self, obj):
obj.setEditorMode('BoneBlacklist', 2) # hide this one

Expand All @@ -418,6 +444,7 @@ def shouldInsertDogbone(self, obj, inChord, outChord):
return outChord.foldsBackOrTurns(inChord, self.theOtherSideOf(obj.Side))

def findPivotIntersection(self, pivot, pivotEdge, edge, refPt, d, color):
# pylint: disable=unused-argument
PathLog.track("(%.2f, %.2f)^%.2f - [(%.2f, %.2f), (%.2f, %.2f)]" % (pivotEdge.Curve.Center.x, pivotEdge.Curve.Center.y, pivotEdge.Curve.Radius, edge.Vertexes[0].Point.x, edge.Vertexes[0].Point.y, edge.Vertexes[1].Point.x, edge.Vertexes[1].Point.y))
ppt = None
pptDistance = 0
Expand Down Expand Up @@ -579,8 +606,8 @@ def dogbone(self, bone):
def tboneHorizontal(self, bone):
angle = bone.angle()
boneAngle = 0
if PathGeom.isRoughly(angle, math.pi) or math.fabs(angle) > math.pi/2:
boneAngle = -math.pi
if math.fabs(angle) > math.pi/2:
boneAngle = math.pi
return self.inOutBoneCommands(bone, boneAngle, self.toolRadius)

def tboneVertical(self, bone):
Expand Down Expand Up @@ -846,12 +873,12 @@ def boneStateList(self, obj):
# If the receiver was loaded from file, then it never generated the bone list.
if not hasattr(self, 'bones'):
self.execute(obj)
for (id, loc, enabled, inaccessible) in self.bones:
for (nr, loc, enabled, inaccessible) in self.bones:
item = state.get(loc)
if item:
item[2].append(id)
item[2].append(nr)
else:
state[loc] = (enabled, inaccessible, [id])
state[loc] = (enabled, inaccessible, [nr])
return state


Expand All @@ -862,6 +889,7 @@ class TaskPanel:
def __init__(self, obj):
self.obj = obj
self.form = FreeCADGui.PySideUic.loadUi(":/panels/DogboneEdit.ui")
self.s = None
FreeCAD.ActiveDocument.openTransaction(translate("Path_DressupDogbone", "Edit Dogbone Dress-up"))

def reject(self):
Expand Down Expand Up @@ -979,14 +1007,16 @@ def __del__(self):
PST.clear()

def addSelection(self, doc, obj, sub, pnt):
# pylint: disable=unused-argument
FreeCADGui.doCommand('Gui.Selection.addSelection(FreeCAD.ActiveDocument.' + obj + ')')
FreeCADGui.updateGui()


class ViewProviderDressup:

def __init__(self, vobj):
vobj.Proxy = self
self.vobj = vobj
self.obj = None

def attach(self, vobj):
self.obj = vobj.Object
Expand All @@ -1005,6 +1035,7 @@ def claimChildren(self):
return [self.obj.Base]

def setEdit(self, vobj, mode=0):
# pylint: disable=unused-argument
FreeCADGui.Control.closeDialog()
panel = TaskPanel(vobj.Object)
FreeCADGui.Control.showDialog(panel)
Expand All @@ -1019,6 +1050,7 @@ def __setstate__(self, state):

def onDelete(self, arg1=None, arg2=None):
'''this makes sure that the base operation is added back to the project and visible'''
# pylint: disable=unused-argument
FreeCADGui.ActiveDocument.getObject(arg1.Object.Base.Name).Visibility = True
job = PathUtils.findParentJob(arg1.Object)
job.Proxy.addOperation(arg1.Object.Base, arg1.Object)
Expand All @@ -1030,20 +1062,21 @@ def Create(base, name='DogboneDressup'):
'''
Create(obj, name='DogboneDressup') ... dresses the given PathProfile/PathContour object with dogbones.
'''
obj = FreeCAD.ActiveDocument.addObject('Path::FeaturePython', 'DogboneDressup')
obj = FreeCAD.ActiveDocument.addObject('Path::FeaturePython', name)
dbo = ObjectDressup(obj, base)
job = PathUtils.findParentJob(base)
job.Proxy.addOperation(obj, base)

if FreeCAD.GuiUp:
ViewProviderDressup(obj.ViewObject)
obj.ViewObject.Proxy = ViewProviderDressup(obj.ViewObject)
obj.Base.ViewObject.Visibility = False

dbo.setup(obj, True)
return obj


class CommandDressupDogbone:
# pylint: disable=no-init

def GetResources(self):
return {'Pixmap': 'Path-Dressup',
Expand All @@ -1054,7 +1087,7 @@ def IsActive(self):
if FreeCAD.ActiveDocument is not None:
for o in FreeCAD.ActiveDocument.Objects:
if o.Name[:3] == "Job":
return True
return True
return False

def Activated(self):
Expand Down

0 comments on commit 8769618

Please sign in to comment.