force strict ISO C++ (-Wpedantic)

for Drawing, Image, Inspection, Mesh, MeshPart, Part, Path, Points, Raytracing, ReverseEngineering, Spreadsheet, Start, Surface, Web TODO: fix several -Woverflow in area
FreeCAD · Sep 18, 2019 · a247b7e · a247b7e
1 parent f7c3cba
commit a247b7e
Show file tree

Hide file tree

Showing 51 changed files with 216 additions and 211 deletions.
diff --git a/src/Mod/Drawing/Gui/Command.cpp b/src/Mod/Drawing/Gui/Command.cpp
@@ -50,7 +50,7 @@ using namespace std;
 // CmdDrawingOpen
 //===========================================================================
 
-DEF_STD_CMD(CmdDrawingOpen);
+DEF_STD_CMD(CmdDrawingOpen)
 
 CmdDrawingOpen::CmdDrawingOpen()
   : Command("Drawing_Open")
@@ -86,7 +86,7 @@ void CmdDrawingOpen::activated(int iMsg)
 // Drawing_NewPage
 //===========================================================================
 
-DEF_STD_CMD_ACL(CmdDrawingNewPage);
+DEF_STD_CMD_ACL(CmdDrawingNewPage)
 
 CmdDrawingNewPage::CmdDrawingNewPage()
   : Command("Drawing_NewPage")
@@ -263,7 +263,7 @@ bool CmdDrawingNewPage::isActive(void)
 // Drawing_NewA3Landscape
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingNewA3Landscape);
+DEF_STD_CMD_A(CmdDrawingNewA3Landscape)
 
 CmdDrawingNewA3Landscape::CmdDrawingNewA3Landscape()
   : Command("Drawing_NewA3Landscape")
@@ -302,7 +302,7 @@ bool CmdDrawingNewA3Landscape::isActive(void)
 // Drawing_NewView
 //===========================================================================
 
-DEF_STD_CMD(CmdDrawingNewView);
+DEF_STD_CMD(CmdDrawingNewView)
 
 CmdDrawingNewView::CmdDrawingNewView()
   : Command("Drawing_NewView")
@@ -381,7 +381,7 @@ void CmdDrawingNewView::activated(int iMsg)
 // Drawing_OrthoView
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingOrthoViews);
+DEF_STD_CMD_A(CmdDrawingOrthoViews)
 
 CmdDrawingOrthoViews::CmdDrawingOrthoViews()
   : Command("Drawing_OrthoViews")
@@ -431,7 +431,7 @@ bool CmdDrawingOrthoViews::isActive(void)
 // Drawing_OpenBrowserView
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingOpenBrowserView);
+DEF_STD_CMD_A(CmdDrawingOpenBrowserView)
 
 CmdDrawingOpenBrowserView::CmdDrawingOpenBrowserView()
   : Command("Drawing_OpenBrowserView")
@@ -469,7 +469,7 @@ bool CmdDrawingOpenBrowserView::isActive(void)
 // Drawing_Annotation
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingAnnotation);
+DEF_STD_CMD_A(CmdDrawingAnnotation)
 
 CmdDrawingAnnotation::CmdDrawingAnnotation()
   : Command("Drawing_Annotation")
@@ -517,7 +517,7 @@ bool CmdDrawingAnnotation::isActive(void)
 // Drawing_Clip
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingClip);
+DEF_STD_CMD_A(CmdDrawingClip)
 
 CmdDrawingClip::CmdDrawingClip()
   : Command("Drawing_Clip")
@@ -562,7 +562,7 @@ bool CmdDrawingClip::isActive(void)
 // Drawing_Symbol
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingSymbol);
+DEF_STD_CMD_A(CmdDrawingSymbol)
 
 CmdDrawingSymbol::CmdDrawingSymbol()
   : Command("Drawing_Symbol")
@@ -622,7 +622,7 @@ bool CmdDrawingSymbol::isActive(void)
 // Drawing_ExportPage
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingExportPage);
+DEF_STD_CMD_A(CmdDrawingExportPage)
 
 CmdDrawingExportPage::CmdDrawingExportPage()
   : Command("Drawing_ExportPage")
@@ -678,7 +678,7 @@ bool CmdDrawingExportPage::isActive(void)
 // Drawing_ProjectShape
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingProjectShape);
+DEF_STD_CMD_A(CmdDrawingProjectShape)
 
 CmdDrawingProjectShape::CmdDrawingProjectShape()
   : Command("Drawing_ProjectShape")
@@ -714,7 +714,7 @@ bool CmdDrawingProjectShape::isActive(void)
 // Drawing_Draft_View
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingDraftView);
+DEF_STD_CMD_A(CmdDrawingDraftView)
 
 CmdDrawingDraftView::CmdDrawingDraftView()
   : Command("Drawing_DraftView")
@@ -745,7 +745,7 @@ bool CmdDrawingDraftView::isActive(void)
 // Drawing_Spreadheet_View
 //===========================================================================
 
-DEF_STD_CMD_A(CmdDrawingSpreadsheetView);
+DEF_STD_CMD_A(CmdDrawingSpreadsheetView)
 
 CmdDrawingSpreadsheetView::CmdDrawingSpreadsheetView()
   : Command("Drawing_SpreadsheetView")

diff --git a/src/Mod/Image/Gui/Command.cpp b/src/Mod/Image/Gui/Command.cpp
@@ -44,7 +44,7 @@
 
 using namespace ImageGui;
 
-DEF_STD_CMD(CmdImageOpen);
+DEF_STD_CMD(CmdImageOpen)
 
 CmdImageOpen::CmdImageOpen()
   : Command("Image_Open")
@@ -92,7 +92,7 @@ void CmdImageOpen::activated(int iMsg)
 }
 
 //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-DEF_STD_CMD_A(CmdCreateImagePlane);
+DEF_STD_CMD_A(CmdCreateImagePlane)
 
 CmdCreateImagePlane::CmdCreateImagePlane()
     :Command("Image_CreateImagePlane")
@@ -166,7 +166,7 @@ bool CmdCreateImagePlane::isActive()
 }
 
 //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-DEF_STD_CMD(CmdImageScaling);
+DEF_STD_CMD(CmdImageScaling)
 
 CmdImageScaling::CmdImageScaling()
   : Command("Image_Scaling")

diff --git a/src/Mod/Inspection/App/InspectionFeature.cpp b/src/Mod/Inspection/App/InspectionFeature.cpp
@@ -493,7 +493,7 @@ float InspectNominalShape::getDistance(const Base::Vector3f& point)
 
 // ----------------------------------------------------------------
 
-TYPESYSTEM_SOURCE(Inspection::PropertyDistanceList, App::PropertyLists);
+TYPESYSTEM_SOURCE(Inspection::PropertyDistanceList, App::PropertyLists)
 
 PropertyDistanceList::PropertyDistanceList()
 {

diff --git a/src/Mod/Inspection/Gui/Command.cpp b/src/Mod/Inspection/Gui/Command.cpp
@@ -40,7 +40,7 @@
 #include "ViewProviderInspection.h"
 
 
-DEF_STD_CMD_A(CmdVisualInspection);
+DEF_STD_CMD_A(CmdVisualInspection)
 
 CmdVisualInspection::CmdVisualInspection()
   : Command("Inspection_VisualInspection")
@@ -66,7 +66,7 @@ bool CmdVisualInspection::isActive(void)
 
 //--------------------------------------------------------------------------------------
 
-DEF_STD_CMD_A(CmdInspectElement);
+DEF_STD_CMD_A(CmdInspectElement)
 
 CmdInspectElement::CmdInspectElement()
   : Command("Inspection_InspectElement")

diff --git a/src/Mod/Mesh/App/Core/Algorithm.h b/src/Mod/Mesh/App/Core/Algorithm.h
@@ -511,6 +511,6 @@ class MeshExport MeshRefNormalToPoints
     std::vector<Base::Vector3f> _norm;
 };
 
-}; // namespace MeshCore 
+} // namespace MeshCore 
 
 #endif  // MESH_ALGORITHM_H 
diff --git a/src/Mod/Mesh/App/Core/Helpers.h b/src/Mod/Mesh/App/Core/Helpers.h
@@ -97,7 +97,7 @@ inline void MeshHelpPoint::Set (unsigned long ulCorner, unsigned long ulFacet, c
 {
   _ulInd = (ulFacet << 2) | ulCorner;
   _clPt  = rclPt;
-};
+}
 
 inline bool MeshHelpPoint::operator < (const MeshHelpPoint &rclObj) const
 {

diff --git a/src/Mod/Mesh/App/Core/SetOperations.h b/src/Mod/Mesh/App/Core/SetOperations.h
@@ -185,6 +185,6 @@ class MeshExport SetOperations
 };
 
 
-}; // namespace MeshCore
+} // namespace MeshCore
 
 #endif  // MESH_SETOPERATIONS_H
diff --git a/src/Mod/Mesh/App/MeshProperties.cpp b/src/Mod/Mesh/App/MeshProperties.cpp
@@ -44,9 +44,9 @@
 
 using namespace Mesh;
 
-TYPESYSTEM_SOURCE(Mesh::PropertyNormalList, App::PropertyLists);
-TYPESYSTEM_SOURCE(Mesh::PropertyCurvatureList , App::PropertyLists);
-TYPESYSTEM_SOURCE(Mesh::PropertyMeshKernel , App::PropertyComplexGeoData);
+TYPESYSTEM_SOURCE(Mesh::PropertyNormalList, App::PropertyLists)
+TYPESYSTEM_SOURCE(Mesh::PropertyCurvatureList , App::PropertyLists)
+TYPESYSTEM_SOURCE(Mesh::PropertyMeshKernel , App::PropertyComplexGeoData)
 
 PropertyNormalList::PropertyNormalList()
 {