calling close() causes the MDI view to get deleted as soon as possibl…

…e while deleteLater() waits until the GUI is responsive
FreeCAD · Jul 17, 2017 · b36686e · b36686e
1 parent 44fba58
commit b36686e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Gui/Document.cpp b/src/Gui/Document.cpp
@@ -1204,6 +1204,8 @@ bool Document::isLastView(void)
  */
 bool Document::canClose ()
 {
+    if (d->_isClosing)
+        return true;
     if (!getDocument()->isClosable()) {
         QMessageBox::warning(getActiveView(),
             QObject::tr("Document not closable"),

diff --git a/src/Gui/MDIView.cpp b/src/Gui/MDIView.cpp
@@ -92,10 +92,13 @@ void MDIView::deleteSelf()
     // #0001023: Crash when quitting after using Windows > Tile
     // Use deleteLater() instead of delete operator.
     QWidget* parent = this->parentWidget();
-    if (qobject_cast<QMdiSubWindow*>(parent))
-        parent->deleteLater();
-    else
-        this->deleteLater();
+    if (qobject_cast<QMdiSubWindow*>(parent)) {
+        // https://forum.freecadweb.org/viewtopic.php?f=22&t=23070
+        parent->close();
+    }
+    else {
+        this->close();
+    }
 
     // detach from document
     if (_pcDocument)