core system

force strict ISO C++ (-Wpedantic)
TODO: still a lot of variadic macros are not valid ISO C++

src/3rdParty/salomesmesh/CMakeLists.txt

@@ -7,9 +7,9 @@ SET(SMESH_VERSION_PATCH 1)
 SET(SMESH_VERSION_TWEAK 0)
 
 if(CMAKE_COMPILER_IS_GNUCXX)
-    set(CMAKE_CXX_FLAGS " ${CMAKE_CXX_FLAGS} -Wno-sign-compare -Wno-reorder -Wno-switch -Wno-unused-variable -Wno-unused-but-set-variable -Wno-comment -Wno-unused-parameter -Wno-empty-body")
+    set(CMAKE_CXX_FLAGS " ${CMAKE_CXX_FLAGS} -Wno-sign-compare -Wno-reorder -Wno-switch -Wno-unused-variable -Wno-unused-but-set-variable -Wno-comment -Wno-unused-parameter -Wno-empty-body -Wno-pedantic")
 elseif(CMAKE_COMPILER_IS_CLANGXX)
-    set(CMAKE_CXX_FLAGS " ${CMAKE_CXX_FLAGS} -Wno-sign-compare -Wno-reorder -Wno-switch -Wno-unused-variable -Wno-unused-private-field -Wno-unused-function -Wno-sometimes-uninitialized -Wno-overloaded-virtual -Wno-dynamic-class-memaccess -Wno-comment -Wno-unused-parameter")
+    set(CMAKE_CXX_FLAGS " ${CMAKE_CXX_FLAGS} -Wno-sign-compare -Wno-reorder -Wno-switch -Wno-unused-variable -Wno-unused-private-field -Wno-unused-function -Wno-sometimes-uninitialized -Wno-overloaded-virtual -Wno-dynamic-class-memaccess -Wno-comment -Wno-unused-parameter -Wno-extra-semi")
 endif()
 
 if(CMAKE_COMPILER_IS_CLANGXX)

src/App/Application.cpp

@@ -149,7 +149,7 @@ using namespace boost::program_options;
 # include <new>
 #endif
 
-FC_LOG_LEVEL_INIT("App",true,true);
+FC_LOG_LEVEL_INIT("App",true,true)
 
 //using Base::GetConsole;
 using namespace Base;

src/App/AutoTransaction.cpp

@@ -27,7 +27,7 @@
 #include "Document.h"
 #include "AutoTransaction.h"
 
-FC_LOG_LEVEL_INIT("App",true,true);
+FC_LOG_LEVEL_INIT("App",true,true)
 
 using namespace App;
 

src/App/ComplexGeoData.cpp

@@ -35,10 +35,10 @@
 
 using namespace Data;
 
-TYPESYSTEM_SOURCE_ABSTRACT(Data::Segment , Base::BaseClass);
+TYPESYSTEM_SOURCE_ABSTRACT(Data::Segment , Base::BaseClass)
 
 
-TYPESYSTEM_SOURCE_ABSTRACT(Data::ComplexGeoData , Base::Persistence);
+TYPESYSTEM_SOURCE_ABSTRACT(Data::ComplexGeoData , Base::Persistence)
 
 
 ComplexGeoData::ComplexGeoData(void)

src/App/Document.cpp

@@ -126,7 +126,7 @@ recompute path. Also, it enables more complicated dependencies beyond trees.
 #include "Link.h"
 #include "GeoFeature.h"
 
-FC_LOG_LEVEL_INIT("App", true, true, true);
+FC_LOG_LEVEL_INIT("App", true, true, true)
 
 using Base::Console;
 using Base::streq;

src/App/DocumentObserverPython.h

@@ -111,7 +111,7 @@ class AppExport DocumentObserverPython
     static std::vector<DocumentObserverPython*> _instances;
 
     typedef boost::signals2::connection Connection;
-
+//FIXME: ISO C++11 requires at least one argument for the "..." in a variadic macro
 #define FC_PY_DOC_OBSERVER \
     FC_PY_ELEMENT(CreatedDocument,_1) \
     FC_PY_ELEMENT(DeletedDocument,_1) \

src/App/Expression.cpp

@@ -663,7 +663,7 @@ bool isAnyEqual(const App::any &v1, const App::any &v2) {
 // Expression base-class
 //
 
-TYPESYSTEM_SOURCE_ABSTRACT(App::Expression, Base::BaseClass);
+TYPESYSTEM_SOURCE_ABSTRACT(App::Expression, Base::BaseClass)
 
 Expression::Expression(const DocumentObject *_owner)
     : owner(const_cast<App::DocumentObject*>(_owner)) 
@@ -917,7 +917,7 @@ Expression *Expression::copy() const {
 // UnitExpression class
 //
 
-TYPESYSTEM_SOURCE(App::UnitExpression, App::Expression);
+TYPESYSTEM_SOURCE(App::UnitExpression, App::Expression)
 
 UnitExpression::UnitExpression(const DocumentObject *_owner, const Base::Quantity & _quantity, const std::string &_unitStr)
     : Expression(_owner)
@@ -991,7 +991,7 @@ int UnitExpression::priority() const
 // NumberExpression class
 //
 
-TYPESYSTEM_SOURCE(App::NumberExpression, App::Expression);
+TYPESYSTEM_SOURCE(App::NumberExpression, App::Expression)
 
 NumberExpression::NumberExpression(const DocumentObject *_owner, const Quantity &_quantity)
     : UnitExpression(_owner, _quantity)
@@ -1063,7 +1063,7 @@ bool NumberExpression::isInteger(long *l) const {
 // OperatorExpression class
 //
 
-TYPESYSTEM_SOURCE(App::OperatorExpression, App::Expression);
+TYPESYSTEM_SOURCE(App::OperatorExpression, App::Expression)
 
 OperatorExpression::OperatorExpression(const App::DocumentObject *_owner, Expression * _left, Operator _op, Expression * _right)
     : UnitExpression(_owner)
@@ -1388,7 +1388,7 @@ bool OperatorExpression::isRightAssociative() const
 // FunctionExpression class. This class handles functions with one or two parameters.
 //
 
-TYPESYSTEM_SOURCE(App::FunctionExpression, App::UnitExpression);
+TYPESYSTEM_SOURCE(App::FunctionExpression, App::UnitExpression)
 
 FunctionExpression::FunctionExpression(const DocumentObject *_owner, Function _f, std::vector<Expression *> _args)
     : UnitExpression(_owner)
@@ -2030,7 +2030,7 @@ void FunctionExpression::_visit(ExpressionVisitor &v)
 // VariableExpression class
 //
 
-TYPESYSTEM_SOURCE(App::VariableExpression, App::UnitExpression);
+TYPESYSTEM_SOURCE(App::VariableExpression, App::UnitExpression)
 
 VariableExpression::VariableExpression(const DocumentObject *_owner, ObjectIdentifier _var)
     : UnitExpression(_owner)
@@ -2305,7 +2305,7 @@ void VariableExpression::setPath(const ObjectIdentifier &path)
 // PyObjectExpression class
 //
 
-TYPESYSTEM_SOURCE(App::PyObjectExpression, App::Expression);
+TYPESYSTEM_SOURCE(App::PyObjectExpression, App::Expression)
 
 PyObjectExpression::~PyObjectExpression() {
     if(pyObj) {
@@ -2361,7 +2361,7 @@ boost::any PyObjectExpression::getValueAsAny() const {
 // StringExpression class
 //
 
-TYPESYSTEM_SOURCE(App::StringExpression, App::Expression);
+TYPESYSTEM_SOURCE(App::StringExpression, App::Expression)
 
 StringExpression::StringExpression(const DocumentObject *_owner, const std::string &_text)
     : Expression(_owner)
@@ -2406,7 +2406,7 @@ Expression *StringExpression::_copy() const
     return new StringExpression(owner, text);
 }
 
-TYPESYSTEM_SOURCE(App::ConditionalExpression, App::Expression);
+TYPESYSTEM_SOURCE(App::ConditionalExpression, App::Expression)
 
 ConditionalExpression::ConditionalExpression(const DocumentObject *_owner, Expression *_condition, Expression *_trueExpr, Expression *_falseExpr)
     : Expression(_owner)
@@ -2489,7 +2489,7 @@ void ConditionalExpression::_visit(ExpressionVisitor &v)
     falseExpr->visit(v);
 }
 
-TYPESYSTEM_SOURCE(App::ConstantExpression, App::NumberExpression);
+TYPESYSTEM_SOURCE(App::ConstantExpression, App::NumberExpression)
 
 ConstantExpression::ConstantExpression(const DocumentObject *_owner, std::string _name, const Quantity & _quantity)
     : NumberExpression(_owner, _quantity)
@@ -2512,7 +2512,7 @@ int ConstantExpression::priority() const
     return 20;
 }
 
-TYPESYSTEM_SOURCE_ABSTRACT(App::BooleanExpression, App::NumberExpression);
+TYPESYSTEM_SOURCE_ABSTRACT(App::BooleanExpression, App::NumberExpression)
 
 BooleanExpression::BooleanExpression(const DocumentObject *_owner, bool _value)
     : NumberExpression(_owner, Quantity(_value ? 1.0 : 0.0))
@@ -2524,7 +2524,7 @@ Expression *BooleanExpression::_copy() const
     return new BooleanExpression(owner, getValue() > 0.5 ? true : false);
 }
 
-TYPESYSTEM_SOURCE(App::RangeExpression, App::Expression);
+TYPESYSTEM_SOURCE(App::RangeExpression, App::Expression)
 
 RangeExpression::RangeExpression(const DocumentObject *_owner, const std::string &begin, const std::string &end)
     : Expression(_owner), begin(begin), end(end)

src/App/Extension.cpp

@@ -38,7 +38,7 @@
 /* We do not use a standard property macro for type initiation. The reason is that we have the first
  * PropertyData in the extension chain, there is no parent property data. 
  */
-EXTENSION_TYPESYSTEM_SOURCE_P(App::Extension);
+EXTENSION_TYPESYSTEM_SOURCE_P(App::Extension)
 const App::PropertyData * App::Extension::extensionGetPropertyDataPtr(void){return &propertyData;}
 const App::PropertyData & App::Extension::extensionGetPropertyData(void) const{return propertyData;}
 App::PropertyData App::Extension::propertyData;

src/App/Extension.h

@@ -72,7 +72,7 @@ void * _class_::create(void){return 0;}
 
 /// define to implement a subclass of Base::BaseClass
 #define EXTENSION_TYPESYSTEM_SOURCE(_class_, _parentclass_) \
-EXTENSION_TYPESYSTEM_SOURCE_P(_class_);\
+EXTENSION_TYPESYSTEM_SOURCE_P(_class_)\
 void _class_::init(void){\
   initExtensionSubclass(_class_::classTypeId, #_class_ , #_parentclass_, &(_class_::create) ); \
 }
@@ -104,7 +104,7 @@ private: \
   static App::PropertyData propertyData
 
 #define EXTENSION_PROPERTY_SOURCE(_class_, _parentclass_) \
-EXTENSION_TYPESYSTEM_SOURCE_P(_class_);\
+EXTENSION_TYPESYSTEM_SOURCE_P(_class_)\
 const App::PropertyData * _class_::extensionGetPropertyDataPtr(void){return &propertyData;} \
 const App::PropertyData & _class_::extensionGetPropertyData(void) const{return propertyData;} \
 App::PropertyData _class_::propertyData; \
@@ -114,7 +114,7 @@ void _class_::init(void){\
 }
 
 #define EXTENSION_PROPERTY_SOURCE_TEMPLATE(_class_, _parentclass_) \
-EXTENSION_TYPESYSTEM_SOURCE_TEMPLATE(_class_);\
+EXTENSION_TYPESYSTEM_SOURCE_TEMPLATE(_class_)\
 template<> App::PropertyData _class_::propertyData = App::PropertyData(); \
 template<> const App::PropertyData * _class_::extensionGetPropertyDataPtr(void){return &propertyData;} \
 template<> const App::PropertyData & _class_::extensionGetPropertyData(void) const{return propertyData;} \

src/App/ExtensionContainer.h

@@ -134,7 +134,7 @@ class AppExport ExtensionContainer : public App::PropertyContainer
     template<typename ExtensionT>
     ExtensionT* getExtensionByType(bool no_except=false, bool derived=true) const {
         return static_cast<ExtensionT*>(getExtension(ExtensionT::getExtensionClassTypeId(),derived,no_except));
-    };
+    }
 
     //get all extensions which have the given base class
     std::vector<Extension*> getExtensionsDerivedFrom(Base::Type type) const;
@@ -146,7 +146,7 @@ class AppExport ExtensionContainer : public App::PropertyContainer
                 typevec.push_back(static_cast<ExtensionT*>(entry.second));
         }
         return typevec;
-    };
+    }
 
     ExtensionIterator extensionBegin() {return _extensions.begin();};
     ExtensionIterator extensionEnd() {return _extensions.end();};

src/App/GroupExtensionPyImp.cpp

@@ -129,8 +129,7 @@ PyObject* GroupExtensionPy::addObjects(PyObject *args) {
     std::string error = std::string("type must be list of 'DocumentObject', not ");
     error += object->ob_type->tp_name;
     throw Base::TypeError(error);
-};
-
+}
 
 PyObject* GroupExtensionPy::setObjects(PyObject *args) {
 

src/App/Link.h

@@ -39,6 +39,8 @@
 #include "FeaturePython.h"
 #include "GroupExtension.h"
 
+//FIXME: ISO C++11 requires at least one argument for the "..." in a variadic macro
+
 #define LINK_THROW(_type,_msg) do{\
     if(FC_LOG_INSTANCE.isEnabled(FC_LOGLEVEL_LOG))\
         FC_ERR(_msg);\

src/App/Property.cpp

@@ -43,7 +43,7 @@ using namespace App;
 // Property
 //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
-TYPESYSTEM_SOURCE_ABSTRACT(App::Property , Base::Persistence);
+TYPESYSTEM_SOURCE_ABSTRACT(App::Property , Base::Persistence)
 
 //**************************************************************************
 // Construction/Destruction
@@ -271,4 +271,4 @@ void PropertyListsBase::_setPyObject(PyObject *value) {
 // PropertyLists
 //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
-TYPESYSTEM_SOURCE_ABSTRACT(App::PropertyLists , App::Property);
+TYPESYSTEM_SOURCE_ABSTRACT(App::PropertyLists , App::Property)

src/App/PropertyContainer.cpp

@@ -46,7 +46,7 @@ using namespace App;
 using namespace Base;
 using namespace std;
 
-TYPESYSTEM_SOURCE(App::PropertyContainer,Base::Persistence);
+TYPESYSTEM_SOURCE(App::PropertyContainer,Base::Persistence)
 
 
 //**************************************************************************

src/App/PropertyContainer.h

@@ -293,7 +293,7 @@ private: \
   static App::PropertyData propertyData 
 /// 
 #define PROPERTY_SOURCE(_class_, _parentclass_) \
-TYPESYSTEM_SOURCE_P(_class_);\
+TYPESYSTEM_SOURCE_P(_class_)\
 const App::PropertyData * _class_::getPropertyDataPtr(void){return &propertyData;} \
 const App::PropertyData & _class_::getPropertyData(void) const{return propertyData;} \
 App::PropertyData _class_::propertyData; \
@@ -303,7 +303,7 @@ void _class_::init(void){\
 }
 
 #define PROPERTY_SOURCE_ABSTRACT(_class_, _parentclass_) \
-TYPESYSTEM_SOURCE_ABSTRACT_P(_class_);\
+TYPESYSTEM_SOURCE_ABSTRACT_P(_class_)\
 const App::PropertyData * _class_::getPropertyDataPtr(void){return &propertyData;} \
 const App::PropertyData & _class_::getPropertyData(void) const{return propertyData;} \
 App::PropertyData _class_::propertyData; \
@@ -321,7 +321,7 @@ template<> void * _class_::create(void){\
 }
 
 #define PROPERTY_SOURCE_TEMPLATE(_class_, _parentclass_) \
-TYPESYSTEM_SOURCE_TEMPLATE(_class_);\
+TYPESYSTEM_SOURCE_TEMPLATE(_class_)\
 template<> App::PropertyData _class_::propertyData = App::PropertyData(); \
 template<> const App::PropertyData * _class_::getPropertyDataPtr(void){return &propertyData;} \
 template<> const App::PropertyData & _class_::getPropertyData(void) const{return propertyData;} \

src/App/PropertyContainerPyImp.cpp

@@ -41,7 +41,7 @@
 #include "PropertyContainerPy.h"
 #include "PropertyContainerPy.cpp"
 
-FC_LOG_LEVEL_INIT("Property", true, 2);
+FC_LOG_LEVEL_INIT("Property", true, 2)
 
 using namespace App;
 

src/App/PropertyExpressionEngine.cpp

@@ -43,7 +43,7 @@ using namespace App;
 using namespace Base;
 using namespace boost;
 
-TYPESYSTEM_SOURCE_ABSTRACT(App::PropertyExpressionContainer , App::PropertyXLinkContainer);
+TYPESYSTEM_SOURCE_ABSTRACT(App::PropertyExpressionContainer , App::PropertyXLinkContainer)
 
 static std::set<PropertyExpressionContainer*> _ExprContainers;
 
@@ -73,7 +73,7 @@ void PropertyExpressionContainer::slotRelabelDocument(const App::Document &doc)
 
 ///////////////////////////////////////////////////////////////////////////////////////
 
-TYPESYSTEM_SOURCE(App::PropertyExpressionEngine , App::PropertyExpressionContainer);
+TYPESYSTEM_SOURCE(App::PropertyExpressionEngine , App::PropertyExpressionContainer)
 
 /**
  * @brief Construct a new PropertyExpressionEngine object.

src/App/PropertyFile.cpp

@@ -53,7 +53,7 @@ using namespace std;
 // PropertyFileIncluded
 //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
-TYPESYSTEM_SOURCE(App::PropertyFileIncluded , App::Property);
+TYPESYSTEM_SOURCE(App::PropertyFileIncluded , App::Property)
 
 
 PropertyFileIncluded::PropertyFileIncluded()
@@ -626,7 +626,7 @@ unsigned int PropertyFileIncluded::getMemSize (void) const
 // PropertyFile
 //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
-TYPESYSTEM_SOURCE(App::PropertyFile , App::PropertyString);
+TYPESYSTEM_SOURCE(App::PropertyFile , App::PropertyString)
 
 PropertyFile::PropertyFile()
 {