Skip to content

Commit

Permalink
Added support for lithuanian, valencian, indonesian and filipino
Browse files Browse the repository at this point in the history
  • Loading branch information
@yorikvanhavre
yorikvanhavre committed Feb 21, 2018
1 parent 35ee3f0 commit b9e1cbb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/Gui/Language/Translator.cpp
View file
Expand Up @@ -159,6 +159,10 @@ Translator::Translator()
d->mapLanguageTopLevelDomain[QT_TR_NOOP("Galician" )] = "gl";
d->mapLanguageTopLevelDomain[QT_TR_NOOP("Kabyle" )] = "kab";
d->mapLanguageTopLevelDomain[QT_TR_NOOP("Korean" )] = "ko";
d->mapLanguageTopLevelDomain[QT_TR_NOOP("Filipino" )] = "fil";
d->mapLanguageTopLevelDomain[QT_TR_NOOP("Indonesian" )] = "id";
d->mapLanguageTopLevelDomain[QT_TR_NOOP("Lithuanian" )] = "lt";
d->mapLanguageTopLevelDomain[QT_TR_NOOP("Valencian" )] = "val-ES";

d->activatedLanguage = "English";

Expand Down
2 changes: 1 addition & 1 deletion src/Tools/updatefromcrowdin.py
View file
Expand Up @@ -93,7 +93,7 @@
["TechDraw","../Mod/TechDraw/Gui/Resources/translations","../Mod/TechDraw/Gui/Resources/TechDraw.qrc"],
]

default_languages = "af zh-CN zh-TW hr cs nl fi fr de hu ja no pl pt-PT ro ru sr es-ES sv-SE uk it pt-BR el sk tr sl eu ca gl kab ko"
default_languages = "af zh-CN zh-TW hr cs nl fi fr de hu ja no pl pt-PT ro ru sr es-ES sv-SE uk it pt-BR el sk tr sl eu ca gl kab ko fil id lt val-ES"

def updateqrc(qrcpath,lncode):
"updates a qrc file with the given translation entry"
Expand Down

1 comment on commit b9e1cbb

@quikshot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yorik, I think that Catalan and Valencian, should not be split into two different languages, since they are the same language.

Valencian is the Catalan language spoken in Valencian Comunity, but it is the same as separating Peruan for Spanish or Argentinian. Or Australian/American/English. You usually say English from America, or Spanish from LatinAmerica. Different places, same language. So the same should be for Catalan and Catalan from Valencia. This is specially significant because there is a political intent to divide and conquer in Spain.

So I believe it should be the same name. You can see here the ISO name with both catalan/valencian.
https://iso639-3.sil.org/code/cat

For instance:
-Català
-Català-Valencià

From: https://en.wikipedia.org/wiki/IETF_language_tag
Not all linguistic regions can be represented with a valid region subtag: the subnational regional dialects of a primary language are registered as variant subtags. For example, the valencia variant subtag for the Valencian dialect of Catalan is registered in the Language Subtag Registry with the prefix ca. As this dialect is spoken almost exclusively in Spain, the region subtag ES can normally be omitted.

Please sign in to comment.