removed useless std::move on const and unmovable objects

FreeCAD · Nov 21, 2019 · bbbabf9 · bbbabf9
1 parent 5ee4a2e
commit bbbabf9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/App/ExpressionParser.tab.c b/src/App/ExpressionParser.tab.c
@@ -1835,7 +1835,7 @@ yyparse (void)
 
   case 66:
 #line 190 "ExpressionParser.y" /* yacc.c:1646  */
-    { (yyvsp[-1].expr)->addComponent(std::move((yyvsp[0].component))); (yyval.expr) = (yyvsp[-1].expr); }
+    { (yyvsp[-1].expr)->addComponent((yyvsp[0].component)); (yyval.expr) = (yyvsp[-1].expr); }
 #line 1840 "ExpressionParser.tab.c" /* yacc.c:1646  */
     break;
 

diff --git a/src/App/ObjectIdentifier.cpp b/src/App/ObjectIdentifier.cpp
@@ -1857,7 +1857,7 @@ void ObjectIdentifier::resolveAmbiguity(ResolveResults &result) {
     if(result.resolvedDocumentObject == owner) {
         setDocumentObjectName(owner,false,std::move(subname));
     }else if(result.flags.test(ResolveByIdentifier))
-        setDocumentObjectName(std::move(result.resolvedDocumentObject),true,std::move(subname));
+        setDocumentObjectName(result.resolvedDocumentObject,true,std::move(subname));
     else
         setDocumentObjectName(
                 String(result.resolvedDocumentObject->Label.getStrValue(),true,false),true,std::move(subname));

diff --git a/src/App/ObjectIdentifier.h b/src/App/ObjectIdentifier.h
@@ -267,7 +267,7 @@ class AppExport ObjectIdentifier {
         documentObjectNameSet = other.documentObjectNameSet;
         localProperty = other.localProperty;
         _cache = std::move(other._cache);
-        _hash = std::move(other._hash);
+        _hash = other._hash;
         return *this;
     }
 

diff --git a/src/App/PropertyLinks.cpp b/src/App/PropertyLinks.cpp
@@ -2161,7 +2161,7 @@ void PropertyLinkSubList::Restore(Base::XMLReader &reader)
     reader.readEndElement("LinkSubList");
 
     // assignment
-    setValues(values,std::move(SubNames),std::move(shadows));
+    setValues(values,SubNames,std::move(shadows));
     _mapped.swap(mapped);
 }
 
@@ -2940,7 +2940,7 @@ void PropertyXLink::setValue(App::DocumentObject *lValue,
     _pcLink=lValue;
     if(docInfo && docInfo->pcDoc)
         stamp=docInfo->pcDoc->LastModifiedDate.getValue();
-    objectName = std::move(name);
+    objectName = name;
     setSubValues(std::move(subs),std::move(shadows));
     hasSetValue();
 }