[TD]fix multiple dimension drag

FreeCAD · Aug 10, 2022 · cb96332 · cb96332
1 parent 730b143
commit cb96332
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/src/Mod/TechDraw/Gui/QGIViewDimension.cpp b/src/Mod/TechDraw/Gui/QGIViewDimension.cpp
@@ -95,7 +95,14 @@ enum SnapMode{
         HorizontalSnap
     };
 
-QGIDatumLabel::QGIDatumLabel()
+enum DragState {
+    NoDrag,
+    DragStarted,
+    Dragging };
+
+
+QGIDatumLabel::QGIDatumLabel() :
+    m_dragState(NoDrag)
 {
     verticalSep = false;
     posX = 0;
@@ -136,10 +143,16 @@ QVariant QGIDatumLabel::itemChange(GraphicsItemChange change, const QVariant &va
             setPrettySel();
         } else {
             setPrettyNormal();
+            if (m_dragState == Dragging) {
+                //stop the drag if we are no longer selected.
+                m_dragState = NoDrag;
+                Q_EMIT dragFinished();
+            }
         }
-        update();
+
     } else if(change == ItemPositionHasChanged && scene()) {
         setLabelCenter();
+        m_dragState = Dragging;
         Q_EMIT dragging(m_ctrl);
     }
 
@@ -164,11 +177,9 @@ void QGIDatumLabel::mouseReleaseEvent(QGraphicsSceneMouseEvent * event)
 {
 //    Base::Console().Message("QGIDL::mouseReleaseEvent()\n");
     m_ctrl = false;
-    if (QLineF(event->screenPos(), event->buttonDownScreenPos(Qt::LeftButton))
-        .length() > 0) {
-        if (scene() && this == scene()->mouseGrabberItem()) {
-            Q_EMIT dragFinished();
-        }
+    if (m_dragState == Dragging) {
+        m_dragState = NoDrag;
+        Q_EMIT dragFinished();
     }
 
     QGraphicsItem::mouseReleaseEvent(event);

diff --git a/src/Mod/TechDraw/Gui/QGIViewDimension.h b/src/Mod/TechDraw/Gui/QGIViewDimension.h
@@ -136,6 +136,8 @@ Q_OBJECT
 
     bool m_isFramed;
     double m_lineWidth;
+
+    int m_dragState;
 
 private:
 };