Skip to content

Commit

Permalink
Attacher: fix superPlacement applied twice in some cases
Browse files Browse the repository at this point in the history
superPlacement was applied twice on line and point attachment modes that
re-use 3d attachment modes code. Fixed.
  • Loading branch information
DeepSOIC committed Apr 21, 2016
1 parent 4313738 commit d6a3d1b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Mod/Part/App/Attacher.cpp
Expand Up @@ -1509,6 +1509,7 @@ Base::Placement AttachEngineLine::calculateAttachedPlacement(Base::Placement ori
AttachEngine3D attacher3D;
attacher3D.setUp(*this);
attacher3D.mapMode = mmode;
attacher3D.superPlacement = Base::Placement(); //superplacement is applied separately here, afterwards. So we are resetting it in sub-attacher to avoid applying it twice!
plm = attacher3D.calculateAttachedPlacement(origPlacement);
plm *= presuperPlacement;
}
Expand Down Expand Up @@ -1677,6 +1678,7 @@ Base::Placement AttachEnginePoint::calculateAttachedPlacement(Base::Placement or
AttachEngine3D attacher3D;
attacher3D.setUp(*this);
attacher3D.mapMode = mmode;
attacher3D.superPlacement = Base::Placement(); //superplacement is applied separately here, afterwards. So we are resetting it in sub-attacher to avoid applying it twice!
plm = attacher3D.calculateAttachedPlacement(origPlacement);
}
plm *= this->superPlacement;
Expand Down

0 comments on commit d6a3d1b

Please sign in to comment.