Skip to content

Commit

Permalink
Draft: improved Python style, checked with flake8
Browse files Browse the repository at this point in the history
  • Loading branch information
@vocx-fc @yorikvanhavre
vocx-fc authored and yorikvanhavre committed Jul 26, 2019
1 parent 1106496 commit edaf03b
Showing 1 changed file with 104 additions and 86 deletions.
190 changes: 104 additions & 86 deletions src/Mod/Draft/TestDraft.py
View file
@@ -1,34 +1,35 @@
# Unit test for the Draft module

#***************************************************************************
#* (c) Yorik van Havre <yorik@uncreated.net> 2013 *
#* *
#* This file is part of the FreeCAD CAx development system. *
#* *
#* This program is free software; you can redistribute it and/or modify *
#* it under the terms of the GNU Lesser General Public License (LGPL) *
#* as published by the Free Software Foundation; either version 2 of *
#* the License, or (at your option) any later version. *
#* for detail see the LICENCE text file. *
#* *
#* FreeCAD is distributed in the hope that it will be useful, *
#* but WITHOUT ANY WARRANTY; without even the implied warranty of *
#* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
#* GNU Library General Public License for more details. *
#* *
#* You should have received a copy of the GNU Library General Public *
#* License along with FreeCAD; if not, write to the Free Software *
#* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 *
#* USA *
#* *
#***************************************************************************/
''' Unit test for the Draft module'''

# ***************************************************************************
# * (c) Yorik van Havre <yorik@uncreated.net> 2013 *
# * *
# * This file is part of the FreeCAD CAx development system. *
# * *
# * This program is free software; you can redistribute it and/or modify *
# * it under the terms of the GNU Lesser General Public License (LGPL) *
# * as published by the Free Software Foundation; either version 2 of *
# * the License, or (at your option) any later version. *
# * for detail see the LICENCE text file. *
# * *
# * FreeCAD is distributed in the hope that it will be useful, *
# * but WITHOUT ANY WARRANTY; without even the implied warranty of *
# * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
# * GNU Library General Public License for more details. *
# * *
# * You should have received a copy of the GNU Library General Public *
# * License along with FreeCAD; if not, write to the Free Software *
# * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 *
# * USA *
# * *
# ***************************************************************************/

import FreeCAD, os, unittest, FreeCADGui, Draft


class DraftTest(unittest.TestCase):

def setUp(self):
# setting a new document to hold the tests
'''Set up a new document to hold the tests'''
if FreeCAD.ActiveDocument:
if FreeCAD.ActiveDocument.Name != "DraftTest":
FreeCAD.newDocument("DraftTest")
Expand All @@ -37,114 +38,131 @@ def setUp(self):
FreeCAD.setActiveDocument("DraftTest")

def testPivy(self):
FreeCAD.Console.PrintLog ('Checking Pivy...\n')
'''Test Pivy'''
FreeCAD.Console.PrintLog('Checking Pivy...\n')
from pivy import coin
c = coin.SoCube()
FreeCADGui.ActiveDocument.ActiveView.getSceneGraph().addChild(c)
self.failUnless(c,"Pivy is not working properly")
self.failUnless(c, "Pivy is not working properly")

# creation tools
# Creation tools

def testLine(self):
FreeCAD.Console.PrintLog ('Checking Draft Line...\n')
Draft.makeLine(FreeCAD.Vector(0,0,0),FreeCAD.Vector(-2,0,0))
self.failUnless(FreeCAD.ActiveDocument.getObject("Line"),"Draft Line failed")
FreeCAD.Console.PrintLog('Checking Draft Line...\n')
Draft.makeLine(FreeCAD.Vector(0, 0, 0), FreeCAD.Vector(-2, 0, 0))
self.failUnless(FreeCAD.ActiveDocument.getObject("Line"),
"Draft Line failed")

def testWire(self):
FreeCAD.Console.PrintLog ('Checking Draft Wire...\n')
Draft.makeWire([FreeCAD.Vector(0,0,0),FreeCAD.Vector(2,0,0),FreeCAD.Vector(2,2,0)])
self.failUnless(FreeCAD.ActiveDocument.getObject("Wire"),"Draft Wire failed")
FreeCAD.Console.PrintLog('Checking Draft Wire...\n')
Draft.makeWire([FreeCAD.Vector(0, 0, 0), FreeCAD.Vector(2, 0, 0),
FreeCAD.Vector(2, 2, 0)])
self.failUnless(FreeCAD.ActiveDocument.getObject("Wire"),
"Draft Wire failed")

def testBSpline(self):
FreeCAD.Console.PrintLog ('Checking Draft BSpline...\n')
Draft.makeBSpline([FreeCAD.Vector(0,0,0),FreeCAD.Vector(2,0,0),FreeCAD.Vector(2,2,0)])
self.failUnless(FreeCAD.ActiveDocument.getObject("BSpline"),"Draft BSpline failed")

FreeCAD.Console.PrintLog('Checking Draft BSpline...\n')
Draft.makeBSpline([FreeCAD.Vector(0, 0, 0), FreeCAD.Vector(2, 0, 0),
FreeCAD.Vector(2, 2, 0)])
self.failUnless(FreeCAD.ActiveDocument.getObject("BSpline"),
"Draft BSpline failed")

def testRectangle(self):
FreeCAD.Console.PrintLog ('Checking Draft Rectangle...\n')
Draft.makeRectangle(4,2)
self.failUnless(FreeCAD.ActiveDocument.getObject("Rectangle"),"Draft Rectangle failed")
FreeCAD.Console.PrintLog('Checking Draft Rectangle...\n')
Draft.makeRectangle(4, 2)
self.failUnless(FreeCAD.ActiveDocument.getObject("Rectangle"),
"Draft Rectangle failed")

def testArc(self):
FreeCAD.Console.PrintLog ('Checking Draft Arc...\n')
FreeCAD.Console.PrintLog('Checking Draft Arc...\n')
Draft.makeCircle(2, startangle=0, endangle=90)
self.failUnless(FreeCAD.ActiveDocument.getObject("Arc"),"Draft Arc failed")
self.failUnless(FreeCAD.ActiveDocument.getObject("Arc"),
"Draft Arc failed")

def testCircle(self):
FreeCAD.Console.PrintLog ('Checking Draft Circle...\n')
FreeCAD.Console.PrintLog('Checking Draft Circle...\n')
Draft.makeCircle(3)
self.failUnless(FreeCAD.ActiveDocument.getObject("Circle"),"Draft Circle failed")
self.failUnless(FreeCAD.ActiveDocument.getObject("Circle"),
"Draft Circle failed")

def testPolygon(self):
FreeCAD.Console.PrintLog ('Checking Draft Polygon...\n')
Draft.makePolygon(5,5)
self.failUnless(FreeCAD.ActiveDocument.getObject("Polygon"),"Draft Polygon failed")
FreeCAD.Console.PrintLog('Checking Draft Polygon...\n')
Draft.makePolygon(5, 5)
self.failUnless(FreeCAD.ActiveDocument.getObject("Polygon"),
"Draft Polygon failed")

def testEllipse(self):
FreeCAD.Console.PrintLog ('Checking Draft Ellipse...\n')
Draft.makeEllipse(5,3)
self.failUnless(FreeCAD.ActiveDocument.getObject("Ellipse"),"Draft Ellipse failed")
FreeCAD.Console.PrintLog('Checking Draft Ellipse...\n')
Draft.makeEllipse(5, 3)
self.failUnless(FreeCAD.ActiveDocument.getObject("Ellipse"),
"Draft Ellipse failed")

def testPoint(self):
FreeCAD.Console.PrintLog ('Checking Draft Point...\n')
Draft.makePoint(5,3,2)
self.failUnless(FreeCAD.ActiveDocument.getObject("Point"),"Draft Point failed")
FreeCAD.Console.PrintLog('Checking Draft Point...\n')
Draft.makePoint(5, 3, 2)
self.failUnless(FreeCAD.ActiveDocument.getObject("Point"),
"Draft Point failed")

def testText(self):
FreeCAD.Console.PrintLog ('Checking Draft Text...\n')
FreeCAD.Console.PrintLog('Checking Draft Text...\n')
Draft.makeText("Testing Draft")
self.failUnless(FreeCAD.ActiveDocument.getObject("Text"),"Draft Text failed")
self.failUnless(FreeCAD.ActiveDocument.getObject("Text"),
"Draft Text failed")

#def testShapeString(self):
# not working ATM because it needs a font file
# FreeCAD.Console.PrintLog ('Checking Draft ShapeString...\n')
# def testShapeString(self):
# '''Not working at this moment because it needs a font file'''
# FreeCAD.Console.PrintLog('Checking Draft ShapeString...\n')
# Draft.makeShapeString("Testing Draft")
# self.failUnless(FreeCAD.ActiveDocument.getObject("ShapeString"),"Draft ShapeString failed")
# self.failUnless(FreeCAD.ActiveDocument.getObject("ShapeString"),
# "Draft ShapeString failed")

def testDimension(self):
FreeCAD.Console.PrintLog ('Checking Draft Dimension...\n')
Draft.makeDimension(FreeCAD.Vector(0,0,0),FreeCAD.Vector(2,0,0),FreeCAD.Vector(1,-1,0))
self.failUnless(FreeCAD.ActiveDocument.getObject("Dimension"),"Draft Dimension failed")
FreeCAD.Console.PrintLog('Checking Draft Dimension...\n')
Draft.makeDimension(FreeCAD.Vector(0, 0, 0), FreeCAD.Vector(2, 0, 0),
FreeCAD.Vector(1, -1, 0))
self.failUnless(FreeCAD.ActiveDocument.getObject("Dimension"),
"Draft Dimension failed")

# modification tools
# Modification tools

def testMove(self):
FreeCAD.Console.PrintLog ('Checking Draft Move...\n')
l = Draft.makeLine(FreeCAD.Vector(0,0,0),FreeCAD.Vector(-2,0,0))
Draft.move(l,FreeCAD.Vector(2,0,0))
self.failUnless(l.Start == FreeCAD.Vector(2,0,0),"Draft Move failed")
FreeCAD.Console.PrintLog('Checking Draft Move...\n')
l = Draft.makeLine(FreeCAD.Vector(0, 0, 0),
FreeCAD.Vector(-2, 0, 0))
Draft.move(l, FreeCAD.Vector(2, 0, 0))
self.failUnless(l.Start == FreeCAD.Vector(2, 0, 0),
"Draft Move failed")

def testCopy(self):
FreeCAD.Console.PrintLog ('Checking Draft Move with copy...\n')
l = Draft.makeLine(FreeCAD.Vector(0,0,0),FreeCAD.Vector(2,0,0))
l2 = Draft.move(l,FreeCAD.Vector(2,0,0),copy=True)
self.failUnless(l2,"Draft Move with copy failed")
FreeCAD.Console.PrintLog('Checking Draft Move with copy...\n')
l = Draft.makeLine(FreeCAD.Vector(0, 0, 0), FreeCAD.Vector(2, 0, 0))
l2 = Draft.move(l, FreeCAD.Vector(2, 0, 0), copy=True)
self.failUnless(l2, "Draft Move with copy failed")

def testRotate(self):
FreeCAD.Console.PrintLog ('Checking Draft Rotate...\n')
l = Draft.makeLine(FreeCAD.Vector(2,0,0),FreeCAD.Vector(4,0,0))
FreeCAD.Console.PrintLog('Checking Draft Rotate...\n')
l = Draft.makeLine(FreeCAD.Vector(2, 0, 0), FreeCAD.Vector(4, 0, 0))
FreeCAD.ActiveDocument.recompute()
Draft.rotate(l,90)
self.assertTrue(l.Start.isEqual(FreeCAD.Vector(0,2,0), 1e-12),"Draft Rotate failed")
Draft.rotate(l, 90)
self.assertTrue(l.Start.isEqual(FreeCAD.Vector(0, 2, 0), 1e-12),
"Draft Rotate failed")

def testOffset(self):
FreeCAD.Console.PrintLog ('Checking Draft Offset...\n')
r = Draft.makeRectangle(4,2)
FreeCAD.Console.PrintLog('Checking Draft Offset...\n')
r = Draft.makeRectangle(4, 2)
FreeCAD.ActiveDocument.recompute()
r2 = Draft.offset(r,FreeCAD.Vector(-1,-1,0),copy=True)
self.failUnless(r2,"Draft Offset failed")
r2 = Draft.offset(r, FreeCAD.Vector(-1, -1, 0), copy=True)
self.failUnless(r2, "Draft Offset failed")

def testCloneOfPart(self):
#test for a bug introduced by changes attachment code
'''Test cloning of parts.
Test for a bug introduced by changes in attachment code.
'''
box = FreeCAD.ActiveDocument.addObject("Part::Box", "Box")
clone = Draft.clone(box)
self.failUnless(clone.hasExtension("Part::AttachExtension"))

# modification tools

def tearDown(self):
FreeCAD.closeDocument("DraftTest")
pass



1 comment on commit edaf03b

@berndhahnebach
Copy link
Contributor

@berndhahnebach berndhahnebach commented on edaf03b Jul 26, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In FEM we use the following to make line length < 100. IMHO this is much better readable:

self.failUnless(
    FreeCAD.ActiveDocument.getObject("Line"),
    "Draft Line failed"
)

than this:

self.failUnless(FreeCAD.ActiveDocument.getObject("Line"),
                       "Draft Line failed")

Please sign in to comment.