Skip to content

Commit

Permalink
Fixed pylint warnings for PathSetupSheet
Browse files Browse the repository at this point in the history
  • Loading branch information
mlampert committed Jul 1, 2019
1 parent 64bd810 commit ef74365
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 5 deletions.
8 changes: 5 additions & 3 deletions src/Mod/Path/PathScripts/PathSetupSheet.py
Expand Up @@ -48,6 +48,8 @@ def translate(context, text, disambig=None):
return PySide.QtCore.QCoreApplication.translate(context, text, disambig)

class Template:
# pylint: disable=no-init

HorizRapid = 'HorizRapid'
VertRapid = 'VertRapid'
SafeHeightOffset = 'SafeHeightOffset'
Expand Down Expand Up @@ -259,9 +261,9 @@ def setOperationProperties(self, obj, opName):
propName = OpPropertyName(opName, prop)
if hasattr(self.obj, propName):
setattr(obj, prop, getattr(self.obj, propName))
except Exception:
except Exception: # pylint: disable=broad-except
PathLog.info("SetupSheet has no support for {}".format(opName))
#traceback.print_exc(exc)
#traceback.print_exc()

def Create(name = 'SetupSheet'):
obj = FreeCAD.ActiveDocument.addObject('App::FeaturePython', name)
Expand All @@ -283,7 +285,7 @@ def prototype(self, name):
return ptt

def RegisterOperation(name, objFactory, setupProperties):
global _RegisteredOps
global _RegisteredOps # pylint: disable=global-statement
_RegisteredOps[name] = _RegisteredOp(objFactory, setupProperties)

def OpNamePrefix(name):
Expand Down
22 changes: 21 additions & 1 deletion src/Mod/Path/PathScripts/PathSetupSheetGui.py
Expand Up @@ -60,6 +60,8 @@ def __init__(self, vobj, name):
vobj.Proxy = self
self.icon = name
# mode = 2
self.obj = None
self.vobj = None

def attach(self, vobj):
PathLog.track()
Expand All @@ -73,12 +75,15 @@ def __getstate__(self):
return None

def __setstate__(self, state):
# pylint: disable=unused-argument
return None

def getDisplayMode(self, mode):
# pylint: disable=unused-argument
return 'Default'

def setEdit(self, vobj, mode=0):
# pylint: disable=unused-argument
PathLog.track()
taskPanel = TaskPanel(vobj)
FreeCADGui.Control.closeDialog()
Expand All @@ -87,6 +92,7 @@ def setEdit(self, vobj, mode=0):
return True

def unsetEdit(self, vobj, mode):
# pylint: disable=unused-argument
FreeCADGui.Control.closeDialog()
return

Expand All @@ -105,6 +111,7 @@ class Delegate(QtGui.QStyledItemDelegate):
# #PathLog.track(index.column(), type(option))

def createEditor(self, parent, option, index):
# pylint: disable=unused-argument
if index.data(self.EditorRole) is None:
editor = PathSetupSheetOpPrototypeGui.Editor(index.data(self.PropertyRole))
index.model().setData(index, editor, self.EditorRole)
Expand All @@ -115,12 +122,14 @@ def setEditorData(self, widget, index):
index.data(self.EditorRole).setEditorData(widget)

def setModelData(self, widget, model, index):
# pylint: disable=unused-argument
PathLog.track(index.row(), index.column())
editor = index.data(self.EditorRole)
editor.setModelData(widget)
index.model().setData(index, editor.prop.displayString(), QtCore.Qt.DisplayRole)

def updateEditorGeometry(self, widget, option, index):
# pylint: disable=unused-argument
widget.setGeometry(option.rect)

class OpTaskPanel:
Expand All @@ -143,7 +152,12 @@ def __init__(self, obj, name, op):
self.props = sorted(op.properties())
self.prototype = op.prototype(name)

# initialized later
self.delegate = None
self.model = None

def updateData(self, topLeft, bottomRight):
# pylint: disable=unused-argument
if 0 == topLeft.column():
isset = self.model.item(topLeft.row(), 0).checkState() == QtCore.Qt.Checked
self.model.item(topLeft.row(), 1).setEnabled(isset)
Expand Down Expand Up @@ -217,7 +231,7 @@ class OpsDefaultEditor:
def __init__(self, obj, form):
self.form = form
self.obj = obj
self.ops = sorted([OpTaskPanel(self.obj, name, op) for name, op in PathUtil.keyValueIter(PathSetupSheet._RegisteredOps)], key = lambda op: op.name)
self.ops = sorted([OpTaskPanel(self.obj, name, op) for name, op in PathUtil.keyValueIter(PathSetupSheet._RegisteredOps)], key = lambda op: op.name) # pylint: disable=protected-access
if form:
parent = form.tabOpDefaults
for op in self.ops:
Expand Down Expand Up @@ -276,6 +290,12 @@ def __init__(self, obj, form):
self.form = form
self.obj = obj

# initialized later
self.clearanceHeightOffs = None
self.safeHeightOffs = None
self.rapidHorizontal = None
self.rapidVertical = None

def reject(self):
pass

Expand Down
2 changes: 1 addition & 1 deletion src/Mod/Path/PathScripts/PathSetupSheetOpPrototypeGui.py
Expand Up @@ -69,7 +69,7 @@ class _PropertyEnumEditor(_PropertyEditor):

def widget(self, parent):
PathLog.track(self.prop.name, self.prop.getEnumValues())
return QtGui.QComboBox(parent);
return QtGui.QComboBox(parent)

def setEditorData(self, widget):
widget.clear()
Expand Down

0 comments on commit ef74365

Please sign in to comment.