Part: Part.CompoundTools.Explode.explodeCompound access a property of... #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...a sometimes null object with an error
Python code, file `src/Mod/Part/CompoundTools/Explode.py`
The `explodeCompound` function can be called in a context without assigning the `ViewObject` property, for example from a command line script.
The error that is fixed by this patch.
```
Traceback (most recent call last):
...
File "/opt/freecad/Mod/Part/CompoundTools/Explode.py", line 23, in explodeCompound
cf.ViewObject.DontUnhideOnDelete = True
AttributeError: 'NoneType' object has no attribute 'DontUnhideOnDelete']
```
Patch submitted by marioamb.
Fix FreeCAD#4421
https://tracker.freecadweb.org/view.php?id=4421
|
Note: have not tested this patch, but it looks correct. Please review. |
chennes
approved these changes
Feb 21, 2021
howetuft
pushed a commit
to howetuft/FreeCAD
that referenced
this pull request
Feb 21, 2021
…rameter ============================================================================ This specific constraint removes the free parameter of the previous implementation. This solves: https://tracker.freecadweb.org/view.php?id=4501 fixes FreeCAD#4501 However, this implementation of equal size produces zero gradients when coordinates of lines are aligned, e.g. vertical or horizontal. These zero gradients, which are mathematically right ruin the diagnosis, which regards corresponding elements as fully constraint (because they are locked from a solver point of view), when they are simply locked, but are movable and constrainable. For this, when the rightful gradient is small enough (<1e-10) it is substituted by a surrogate gradient of 1e-10, which solves the problem with the diagnose, which treats as zero only values under 1e-13 (pivot threshold used in QR decomposition). This special behaviour fixes the wrong detection here: https://forum.freecadweb.org/viewtopic.php?f=8&t=53466&start=40#p464168 It also fixes this one: https://forum.freecadweb.org/viewtopic.php?p=468585#p468587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...a sometimes null object with an error
Python code, file
src/Mod/Part/CompoundTools/Explode.pyThe
explodeCompoundfunction can be called in a context without assigning theViewObjectproperty, for example from a command line script.The error that is fixed by this patch.
Patch submitted by marioamb.
Fix 0004421
https://tracker.freecadweb.org/view.php?id=4421