Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui: Revert PR #4626 (c62239d0b) Tree View Reorder #5192

Closed
wants to merge 1 commit into from

Conversation

chennes
Copy link
Member

@chennes chennes commented Nov 22, 2021

Users on the forums have identified some serious issues with PR #4626: this commit comments out the key changes so that the original author can look into the issues. When necessary the original code is also restored. Note that a standard git revert was unsuccessful due to intervening changes to the codebase, so this was created manually.

See https://forum.freecadweb.org/viewtopic.php?p=548606

Users on the forums have identified some serious issues with this PR:
this commit comments out the key changes so that the original author can
look into the issues. When necessary the original code is also restored.
@chennes chennes marked this pull request as draft November 22, 2021 16:19
@chennes
Copy link
Member Author

chennes commented Nov 22, 2021

See #5195

@freecadci
Copy link

pipeline status for feature branch PR_5192. Pipeline 414384470 was triggered at bc17027. All CI branches and pipelines.

@luzpaz
Copy link
Contributor

luzpaz commented Nov 23, 2021

@looooo perhaps if/after this PR is merged, we should push a new batch of Weekly bundle builds ?

@chennes
Copy link
Member Author

chennes commented Nov 24, 2021

Rather than merge this PR, I figured out the conflict in git revert and did that instead. So PR #4626 has been reverted by commit c9a74d4. @looooo if you feel it's appropriate, we could issue a new Weekly now so the issue introduced does not propagate any further.

@chennes chennes closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants