Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cellular comm interface to generate interrupt from windows thread #1221

Merged

Conversation

chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented May 14, 2024

Description

The API vPortGenerateSimulatedInterruptFromWindowsThread() added in FreeRTOS/FreeRTOS-Kernel#1044 enables the application to define it's own interrupt number and generated a simulated interrupt from windows thread. This reduce the synchronization effort between windows thread and FreeRTOS tasks.
In this PR:

  • Use vPortGenerateSimulatedInterruptFromWindowsThread in the implementation. Creating FreeRTOS task is no longer required in the implementation.
  • Rename prvSetupCommSettings to prvSetupCommState since SetCommState in called in this function.

Test Steps

Running one of the cellular interface demo for hours without problem.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot requested a review from a team as a code owner May 14, 2024 03:12
@chinglee-iot chinglee-iot marked this pull request as draft May 14, 2024 03:29
@chinglee-iot chinglee-iot marked this pull request as ready for review May 14, 2024 06:34
@chinglee-iot chinglee-iot merged commit 6518cb1 into FreeRTOS:main May 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants