Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: take dynamic asset id into account with forc-client #5987

Merged
merged 3 commits into from May 10, 2024
Merged

feat: take dynamic asset id into account with forc-client #5987

merged 3 commits into from May 10, 2024

Conversation

kayagokalp
Copy link
Member

Description

Base asset ids are dynamic for the newer fuel-core versions. This PR adds capability to query that and use it for forc-client transactions. Also adds a flag max-fee which is required to be set for newer versions of fuel-core.

@kayagokalp kayagokalp added enhancement New feature or request forc-client Everything related to the `forc-client` crate. labels May 10, 2024
@kayagokalp kayagokalp self-assigned this May 10, 2024
@kayagokalp kayagokalp enabled auto-merge (squash) May 10, 2024 16:28
@kayagokalp kayagokalp requested a review from a team May 10, 2024 16:28
sdankel
sdankel reviewed May 10, 2024
View reviewed changes
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a unit test or two for this?

sdankel
sdankel previously approved these changes May 10, 2024
View reviewed changes
@kayagokalp kayagokalp mentioned this pull request May 10, 2024
Open
@kayagokalp
Copy link
Member Author

Could we add a unit test or two for this?

Opened an issue to track but relaying here as well, unfortunately it is very complicated to write complicated tests to forc-client as it requires multiple different network instantiations, hopefully once we have some headroom we can create this infra and test going forward

@kayagokalp kayagokalp requested a review from a team May 10, 2024 17:04
@kayagokalp kayagokalp merged commit 85b9d97 into master May 10, 2024
37 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/dynamic-asset-id branch May 10, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@sdankel sdankel sdankel approved these changes

Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-client Everything related to the `forc-client` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kayagokalp @JoshuaBatty @sdankel