Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic notifications #526

Merged
merged 59 commits into from
Aug 16, 2018
Merged

Epic notifications #526

merged 59 commits into from
Aug 16, 2018

Conversation

karelstriegel
Copy link
Contributor

@karelstriegel karelstriegel commented Aug 10, 2018

Nico Peeters added 30 commits July 18, 2018 12:24
…reate "Generate open requests template"-page in admin
…e-editable' into feature-483-send-open-requests-mail
…-user-of-received-reward

# Conflicts:
#	admin-web/src/main/java/io/fundrequest/platform/admin/claim/service/ClaimModerationServiceImpl.java
#	admin-web/src/main/resources/application.properties
#	common/pom.xml
#	common/src/main/java/io/fundrequest/common/infrastructure/mav/EnumToCapitalizedStringMapper.java
#	core/src/main/java/io/fundrequest/core/request/RequestServiceImpl.java
#	core/src/main/java/io/fundrequest/core/request/fund/FundServiceImpl.java
#	core/src/main/java/io/fundrequest/core/request/fund/dto/FundDto.java
#	core/src/test/java/io/fundrequest/core/request/fund/FundServiceImplTest.java
#	faq/pom.xml
#	github/pom.xml
#	pom.xml
#	tweb/src/main/java/io/fundrequest/platform/tweb/request/RequestController.java
#	tweb/src/main/java/io/fundrequest/platform/tweb/request/RequestRestController.java
#	tweb/src/main/java/io/fundrequest/platform/tweb/request/dto/RequestViewMapper.java
#	tweb/src/main/resources/application.properties
#	tweb/src/main/resources/templates/pages/requests/detail.html
#	tweb/src/test/java/io/fundrequest/platform/tweb/request/RequestControllerTest.java
#	tweb/src/test/java/io/fundrequest/platform/tweb/request/RequestRestControllerTest.java
…pen-requests-mail

# Conflicts:
#	core/src/main/java/io/fundrequest/core/request/RequestServiceImpl.java
#	core/src/main/java/io/fundrequest/core/request/domain/Request.java
#	core/src/test/java/io/fundrequest/core/request/RequestServiceImplTest.java
#	pom.xml
…ail' into feature-487-notify-user-of-received-reward

# Conflicts:
#	admin-web/src/main/java/io/fundrequest/platform/admin/config/ThymeleafConfig.java
#	admin-web/src/main/java/io/fundrequest/platform/admin/notification/NotificationsTemplateService.java
#	admin-web/src/main/resources/templates/fragments/header.html
#	admin-web/src/main/resources/templates/home.html
#	admin-web/src/test/java/io/fundrequest/platform/admin/notification/NotificationsTemplateServiceTest.java
#	core/src/test/java/io/fundrequest/core/notification/infrastructure/NotificationRepositoryTest.java
#	github/src/main/java/io/fundrequest/platform/github/resourceresolver/GithubTemplateResolver.java
#	github/src/main/java/io/fundrequest/platform/github/resourceresolver/GithubTemplateResource.java
#	github/src/test/java/io/fundrequest/platform/github/resourceresolver/GithubTemplateResourceTest.java
#	tweb/src/main/java/io/fundrequest/platform/tweb/infrastructure/thymeleaf/FundrequestDialect.java
#	tweb/src/main/java/io/fundrequest/platform/tweb/infrastructure/thymeleaf/FundrequestExpressionObjectFactory.java
#	tweb/src/main/resources/templates/fragments/top.html
#	tweb/src/test/java/io/fundrequest/platform/tweb/config/ThymeleafSvgConfigTest.java
@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #526 into develop will decrease coverage by 0.87%.
The diff coverage is 65.94%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #526      +/-   ##
=============================================
- Coverage      64.18%   63.31%   -0.88%     
+ Complexity      1101     1049      -52     
=============================================
  Files            301      299       -2     
  Lines           4504     4320     -184     
  Branches         154      150       -4     
=============================================
- Hits            2891     2735     -156     
+ Misses          1526     1501      -25     
+ Partials          87       84       -3
Impacted Files Coverage Δ Complexity Δ
...dmin/claim/service/ClaimModerationServiceImpl.java 83.78% <ø> (ø) 2 <0> (ø) ⬇️
...nfrastructure/thymeleaf/FundsExpressionObject.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...fundrequest/core/request/fund/FundServiceImpl.java 87.09% <ø> (ø) 31 <0> (ø) ⬇️
...venthandler/RequestFundedIntercomEventHandler.java 100% <ø> (ø) 6 <0> (-2) ⬇️
.../io/fundrequest/core/request/fiat/FiatService.java 92.85% <ø> (ø) 7 <0> (ø) ⬇️
.../contract/service/FundRequestContractsService.java 57.57% <ø> (ø) 9 <0> (ø) ⬇️
...fundrequest/platform/tweb/fund/FundController.java 100% <ø> (ø) 11 <0> (ø) ⬇️
...dler/PublishRequestClaimedNotificationHandler.java 100% <ø> (ø) 2 <0> (-2) ⬇️
...o/fundrequest/platform/admin/AdminApplication.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...t/platform/tweb/request/RequestRestController.java 100% <ø> (ø) 3 <0> (ø) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8343eb3...7781770. Read the comment docs.

@nico-ptrs nico-ptrs merged commit d49d8f4 into develop Aug 16, 2018
@nico-ptrs nico-ptrs deleted the epic-notifications branch August 16, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants