Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

Conversation

GabrielSandoval
Copy link

@GabrielSandoval GabrielSandoval commented Mar 13, 2018

@GabrielSandoval GabrielSandoval changed the title [#155929975] Remove #alias_method_chain [#155929975] Rails 5 - Remove #alias_method_chain Mar 13, 2018
@GabrielSandoval GabrielSandoval changed the title [#155929975] Rails 5 - Remove #alias_method_chain [#155929975] Rails 5 upgrade - Remove #alias_method_chain Mar 13, 2018
- #alias_method_chain has been deprecated in Rails 5
See: rails/rails#19434
@GabrielSandoval GabrielSandoval force-pushed the ae-rails_5_upgrade_dependencies-155929975 branch from 716762b to 8759010 Compare March 21, 2018 06:40
Copy link

@kimmy kimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Make gem Rails 5 compatible
Copy link

@kimmy kimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kimmy kimmy changed the base branch from master to ae-rails_5_upgrade_dependencies-155929975 November 27, 2018 02:43
@kimmy kimmy merged commit fb1d6cb into G5:ae-rails_5_upgrade_dependencies-155929975 Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants