Add Rails 5 compatible version #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use kwargs in HTTP request methods in rspec See: rails/rails#18323
- params should be of type Hash on access
- Make gem Rails 5 compatible
- This allows the post method to support both Rails 4 and Rails 5 versions - On Rails 5 applications use `asyncapi_post(url, params: params)` instead of `asyncapi_post(url, params)`
…encies-155929975 Add Rails 5 compatible version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed in this Pull Request:
Upgrade Rails version to ~> 5.1
Use kwargs in HTTP request methods in rspec
Reference: Use kwargs in ActionController::TestCase and ActionDispatch::Integration HTTP methods rails/rails#18323
Manually include the Rails::Pagination module in
Server::V1::JobsControllerReference: davidcelis/api-pagination@45e6068#diff-04c6e90faac2675aa89e2176d2eec7d8