Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #2023

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Master #2023

wants to merge 23 commits into from

Conversation

ChrisMorter
Copy link
Contributor

Merge back changes in this PR from master to develop.

johnamcleod and others added 12 commits October 26, 2021 10:28
…oat (#2021)

* avoid loss of precision in to_default_float

* add tests

* release management

* Updated to compensate for new mypy version (#2016)

* Updated to ignore mypy's new type-abstract error

* Looks like mypy won't quit on this one.

* More type hinting

* Sort

* Another try

* Another try

* Another try

* Go away mypy

* format

* More mypy wards

* Is this error connected?

* Removed unnecessary dummy package

* Another mypy error

* Format

* Fix mypy error. (#2009)

Co-authored-by: sc336 <s.chiu.00@gmail.com>
Co-authored-by: Jesper Nielsen <44195043+jesnie@users.noreply.github.com>
Copy link
Contributor

@sc336 sc336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.19%. Comparing base (81fe1fb) to head (88f0b17).

Current head 88f0b17 differs from pull request most recent head 7d50d81

Please upload reports for the commit 7d50d81 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2023      +/-   ##
===========================================
- Coverage    98.20%   98.19%   -0.01%     
===========================================
  Files           98       97       -1     
  Lines         5502     5494       -8     
===========================================
- Hits          5403     5395       -8     
  Misses          99       99              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants