factor out simplification logic into What4.Simplify #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is an attempt to standardize the simplifier functions into uniform "strategies" that can be combined together. Specifically, each strategy defines separate setup and execution phases. Strategies can be combined by combining these phases separately, so that their individual setup steps still only occur once in the resulting composite strategy. this is motivated by an observation that multiple calls to a given simplification strategy (in the same assumption context) should always use the same cache. However top-level entry point for simplifiers usually implicitly allocates a fresh cache. Multiple executions of that simplifier would therefore not use the same cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an attempt to standardize the simplifier functions into uniform "strategies" that can be combined together. Specifically, each strategy defines separate setup and execution phases. Strategies can be combined by combining these phases separately, so that their individual setup steps still only occur once in the resulting composite strategy.
this is motivated by an observation that multiple calls to a given simplification strategy (in the same
assumption context) should always use the same cache. However top-level entry point for simplifiers usually implicitly allocates a fresh cache. Multiple executions of that simplifier would therefore not use the same cache.