Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change base_uri to use HTTPS instead of HTTP #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martintajur
Copy link

Pipedrive will deprecate HTTP API access on May 11, 2015.

Pipedrive will deprecate HTTP API access on May 11, 2015.
@martintajur
Copy link
Author

Actually found out it is a duplicate of #26 which was submitted already in December 2014.

Please consider merging this — otherwise integrations will break.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.73%) to 70.39% when pulling b79c91e on martintajur:patch-1 into e640075 on GeneralScripting:master.

@ronniebermejo
Copy link

Today was the day, and they really did it. 👊
I'll implement a quick fix by now.
Let me know if there is something I can help with.

thnsk

@tzahif1
Copy link

tzahif1 commented May 12, 2015

I see that there is no update to the main release, and my system just not working with Pipedrive anymore ... Can anyone advise how should I use the pull request version instead?

@ronniebermejo
Copy link

@tzahif1, This what I am doing:
I forked the project, and made the changes right on master, then I am using my own repo until the official gem gets update.

On my gem file replaced the prev gem line with this one:
gem 'pipedrive-ruby', :git => 'git://github.com/ronniebermejo/pipedrive-ruby.git'

(I know you can point to any commit/branch from a gem line but not remember how to doi it right now)

@tzahif1
Copy link

tzahif1 commented May 12, 2015

Thanks, I realized it earlier and did exactly like you :) it works nice so far.
I am just do not understand why such a simple fix could not be fixed in the main project branch.

On May 12, 2015, at 6:42 PM, Ronnie Bermejo notifications@github.com wrote:

@tzahif1 https://github.com/tzahif1, This what I am doing:
I forked the project, and made the changes right on master, then I am using my own repo until the official gem gets update.

On my gem file replaced the prev gem line with this one:
gem 'pipedrive-ruby', :git => 'git://github.com/ronniebermejo/pipedrive-ruby.git'

(I know you can point to any commit/branch from a gem line but not remember how to doi it right now)


Reply to this email directly or view it on GitHub #33 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants