pygmt.show_versions: Warn about incompatible ghostscript versions #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
force-pushed
the
refactor/show_versions
branch
4 times, most recently
from
3142190
to
4ed07fa
Compare
seisman
commented
May 12, 2024
| @@ -110,8 +113,18 @@ def show_versions(file=sys.stdout): | |||
| import subprocess | |||
|
|
|||
| from packaging.requirements import Requirement | |||
| from packaging.version import Version | |||
|
|
|||
| def _get_clib_info() -> dict: | |||
There was a problem hiding this comment.
The pygmt.print_clib_info function was initially added in #176 but has been replaced by pygmt.show_versions in #466 (first appear in v0.1.2).
In this PR, a new private function _get_clib_info is added which returns a dictionary instead of printing a long string.
It's time to retire the print_clib_info function. Since it's rarely used, I think we can just remove it without a deprecation warning. Of course, we should do it in a separate PR so that at least we have a deprecation entry in the v0.13.0 changelog.
seisman
commented
May 12, 2024
seisman
commented
May 12, 2024
seisman
added
enhancement
seisman
force-pushed
the
refactor/show_versions
branch
from
bfeea0c
to
1e4b338
Compare
11 tasks
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
_get_clib_infoto return the dictionary of GMT library information_get_ghostscript_versionusing match-case statement_check_ghostscript_versionwhich return warnings if the installed ghostscript version is problematicprintmultiple times.Address #3242