Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for macOS arp fix #96

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

raymanP
Copy link

@raymanP raymanP commented Dec 22, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Code changes:

  • Did you format your code with Black?
    • black getmac tests
  • Are the linting checks passing?
    • tox -e check
  • Do all tests pass locally?
    • tox
  • Have you updated the CHANGELOG with a summary of your change?
  • Did you add your name to the contributors list in the README?

Summary of changes:

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bc6af1) 82.57% compared to head (d381187) 87.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   82.57%   87.77%   +5.19%     
==========================================
  Files           3        3              
  Lines         924      924              
==========================================
+ Hits          763      811      +48     
+ Misses        161      113      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raymanP
Copy link
Author

raymanP commented Dec 23, 2023

Python 2.7 test setting seems not to be functional anymore
Could be good to remove it's support here as done in 1.0.0-wip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant