GenericSelectTool - Avoid crash

Don't dereference the end() iterator
GoldenCheetah · Jan 18, 2024 · 573967f · 573967f
1 parent a4cc418
commit 573967f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/Charts/GenericSelectTool.cpp b/src/Charts/GenericSelectTool.cpp
@@ -711,11 +711,13 @@ GenericSelectTool::moved(QPointF pos)
                     // lower_bound to value near x
                     QVector<QPointF>::const_iterator i = std::lower_bound(p.begin(), p.end(), x, CompareQPointFX());
 
-                    // collect them away
-                    vals.insert(series, GPointF(i->x(), i->y(), i-p.begin()));
+                    if (i != p.end()) {
+                        // collect them away
+                        vals.insert(series, GPointF(i->x(), i->y(), i-p.begin()));
 
-                    // nearest x?
-                    if (i->x() != 0 && (nearestx == -9999 || (std::fabs(i->x()-xvalue)) < std::fabs((nearestx-xvalue)))) nearestx = i->x();
+                        // nearest x?
+                        if (i->x() != 0 && (nearestx == -9999 || (std::fabs(i->x()-xvalue)) < std::fabs((nearestx-xvalue)))) nearestx = i->x();
+                    }
                 }
 
             }