Port to Qt6 #3983

andreasbuhr · 2021-07-26T16:01:49Z

Hi, I just wanted to let you know about the current state of my efforts to build with Qt 6.2 (dev branch)

With all the changes in the pull requests I created, I just compiled and linked GoldenCheetah successfully with Qt 6.2. No testing has been done so far on any of the pull requests I created.

Next would be testing, modifying the patches to work with both Qt5 and Qt6, and sorting out some remaining issues. Most of the pull requests I created a very low risk, I assume. But some need more testing, most prominently the Qwt upgrade #3956 and the QRegExp->QRegularExpression transition #3960 .
Unfortunately, I will run out of time allocated for this project soon and won't be able to finish it. I'll have to stop working on GoldenCheetah and the open pull requests.

Anyway, I hope that the sequence of pull request generated will be of value to you and I will be around if you have any questions.

liversedge · 2021-07-28T09:38:58Z

Did your GC 6.2QT build actually startup ?

andreasbuhr · 2021-07-28T09:40:12Z

Yes, it started. It loaded the stored activities. It segfaulted after a few clicks.

amtriathlon · 2024-01-13T20:33:54Z

All Qt6 Refactor PRs are merged and master builds using Qt 6.2.4 (without R, Python and KML for now):

We can start testing!

PS: thank you very much, Adreas!

liversedge · 2024-01-13T21:03:13Z

Thank you Ale and so good to see Andreas’ work finally committed.
Will look at python integration. Now might be the time to drop R support?

liversedge · 2024-01-13T21:04:10Z

Also need to get Andreas on the about box contributors list- this was a fantastic effort !

amtriathlon · 2024-01-13T21:15:07Z

Hi Mark, I added Andreas to About Box in 1fb92d1

It looks like R/Python issues are similar to the ones fixed by Andreas, I think we can fix them following the same pattern, not sure about KML since it uses Boost, perhaps we could drop it.

liversedge · 2024-01-13T22:53:38Z

KML is dropped on Windows already I think?
Anyway I think it can be dropped, maybe we clean out in 3.7 since there are lots of features almost no one uses

amtriathlon · 2024-01-15T13:24:38Z

KML is dropped on Windows already I think?

In official builds is dropped for macOS and no one has ever complained, it is included for Windows and Linux builds, but I don't know if it is used.

Anyway I think it can be dropped, maybe we clean out in 3.7 since there are lots of features almost no one uses

Agree, for now I will exclude it from my builds.

andreasbuhr · 2024-01-15T13:38:37Z

Hi,
it is great to see that you found the time to merge all merge requests. Thanks a lot for adding me to the list of contributors, I appreciate it.
😃

amtriathlon · 2024-01-15T13:57:55Z

I continued testing my Windows build using Qt 6.2.4 and it is working pretty well. Except for R/Python which I am planning to review later, all remaining charts in all 3 views are working and they look nice and responsive, even overlay widgets over VLC video is working to my surprise.
@andreasbuhr do you have any recommendation about what QT6 version we should target?

andreasbuhr · 2024-01-15T14:28:21Z

@andreasbuhr do you have any recommendation about what QT6 version we should target?

No sorry. I changed jobs in January 2023 and I am not that deep in Qt any more.

amtriathlon · 2024-01-15T21:26:37Z

Update: Python charts are working when building with Qt 6.2.4 after replacing QRegExp by QRegularExpression in 1f999a3 and 8e2eb3f

liversedge · 2024-01-16T09:01:56Z

Nice one, was worried this was going to be much harder !

@andreasbuhr congratulations on your new job - albeit a year late :)

amtriathlon · 2024-01-16T14:02:52Z

Update: R Charts are also working when building master with Qt 6.2.4 (95b4a49 and 4b40060)

amtriathlon · 2024-01-16T18:08:56Z

Update: CloudDB client code in master is adapted to Qt 6.2.4 too (894eb42, 21faf53, e95608e and c553de5)

amtriathlon · 2024-01-16T19:50:58Z

Update: installing libkml-dev package on Ubuntu 22.04, enabling KML, and building master using Qt 6.2.4 is working, no additional changes required.

Joern-R · 2024-01-17T07:17:42Z

Agree to drop it. Not sure if anybody uses this feature at all. With the port to QT6 I also suggest to put the "WindowsSDK" to status "deprecated". Am Di., 16. Jan. 2024 um 20:51 Uhr schrieb Alejandro Martinez < ***@***.***>:

…

KML is dropped on Windows already I think? In official builds KML is dropped on macOS, on Windows a libkml and Boost version from https://github.com/GoldenCheetah/WindowsSDK are being used, these were built by @Joern-R <https://github.com/Joern-R> long time ago, IIRC. Anyway I think it can be dropped, maybe we clean out in 3.7 since there are lots of features almost no one uses For now I am dropping it from my Windows builds, I will give it another try when I start building on Linux. — Reply to this email directly, view it on GitHub <#3983 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZFBE3NOLMYUXPXGHTJBU3YO3K2ZAVCNFSM5BAM4RR2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBZGQ2DCMBRGA2Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

liversedge · 2024-01-17T11:08:12Z

Update: Python charts are working when building with Qt 6.2.4 after replacing QRegExp by QRegularExpression in 1f999a3 and 8e2eb3f

I think the signals are not connected, so no output occurs?

[11:02:19.724] warning: QObject::connect: No such slot GenericChart::addCurve(QString,QVector,QVector,QStringList,QString,QString,QStringList,QStringList,int,int,int,QString,int,bool,bool,bool,bool) in ../src/Charts/PythonChart.cpp:465 (unknown:0)
[11:02:19.963] warning: QObject::connect: No such slot GenericChart::addCurve(QString,QVector,QVector,QStringList,QString,QString,QStringList,QStringList,int,int,int,QString,int,bool,bool,bool,bool) in ../src/Charts/PythonChart.cpp:465 (unknown:0)

amtriathlon · 2024-01-17T12:28:10Z

Agree to drop it. Not sure if anybody uses this feature at all.

May be we can ask in users forum (?)

With the port to QT6 I also suggest to put the "WindowsSDK" to status "deprecated".

For now we are using some components in AppVeyor builds, since the ABI has not change they still useful.

amtriathlon · 2024-01-17T12:32:46Z

Update: Python charts are working when building with Qt 6.2.4 after replacing QRegExp by QRegularExpression in 1f999a3 and 8e2eb3f

I think the signals are not connected, so no output occurs?

[11:02:19.724] warning: QObject::connect: No such slot GenericChart::addCurve(QString,QVector,QVector,QStringList,QString,QString,QStringList,QStringList,int,int,int,QString,int,bool,bool,bool,bool) in ../src/Charts/PythonChart.cpp:465 (unknown:0)
[11:02:19.963] warning: QObject::connect: No such slot GenericChart::addCurve(QString,QVector,QVector,QStringList,QString,QString,QStringList,QStringList,int,int,int,QString,int,bool,bool,bool,bool) in ../src/Charts/PythonChart.cpp:465 (unknown:0)

Yes, I should have qualified that affirmation, neither of R/Python charts I use and tested use GC Charts, only R Graphics Device/Web Chart.

If we migrate to the new connect syntax, can this be detected at compile time instead of runtime?

liversedge · 2024-01-17T12:44:25Z

Update: Python charts are working when building with Qt 6.2.4 after replacing QRegExp by QRegularExpression in 1f999a3 and 8e2eb3f

I think the signals are not connected, so no output occurs?

[11:02:19.724] warning: QObject::connect: No such slot GenericChart::addCurve(QString,QVector,QVector,QStringList,QString,QString,QStringList,QStringList,int,int,int,QString,int,bool,bool,bool,bool) in ../src/Charts/PythonChart.cpp:465 (unknown:0)
[11:02:19.963] warning: QObject::connect: No such slot GenericChart::addCurve(QString,QVector,QVector,QStringList,QString,QString,QStringList,QStringList,int,int,int,QString,int,bool,bool,bool,bool) in ../src/Charts/PythonChart.cpp:465 (unknown:0)

Yes, I should had qualified that affirmation, neither of R/Python charts I use and tested use GC Charts, only R Graphics Device/Web Chart.

I we migrate to the new connect syntax, can this be detected at compile time instead of runtime?

No worries at all- will look at it today

amtriathlon · 2024-01-18T14:48:47Z

I think the signals are not connected, so no output occurs?

[11:02:19.724] warning: QObject::connect: No such slot GenericChart::addCurve(QString,QVector,QVector,QStringList,QString,QString,QStringList,QStringList,int,int,int,QString,int,bool,bool,bool,bool) in ../src/Charts/PythonChart.cpp:465 (unknown:0)

The problem was caused by 466bdf1, after reversion (42aa241) Python Charts work with GC Charts when building with Qt6

amtriathlon · 2024-01-18T22:52:11Z

Update: 2 crashes due to dereferencing the end() iterator were fixed (bf28d73 and 573967f), while these go silent on Qt5 they crash on Qt6.

amtriathlon · 2024-01-18T22:52:41Z

Main pending issue for me now when building with Qt6 is Metric Trends chart not being correctly saved.

They work initially (new Athlete or existing one used with Qt5 build) and also after View > Reset Layout / Charts > Reset to default, but they become blank after GoldenCheetah restart.

Exporting the same chart (PMC) with the versions using Qt 5.15.2 and Qt 6.5.3 they differ only in LTMSettings, the former can be imported on either version and the second gives a blank chart on both. Supposedly the difference should come from:

GoldenCheetah/src/Charts/GoldenCheetah.cpp

Lines 970 to 976 in 573967f

    
           if (QString(p.typeName()) == "LTMSettings") { 
        
               QByteArray marshall; 
        
               QDataStream s(&marshall, QIODevice::WriteOnly); 
        
               LTMSettings x = p.read(this).value<LTMSettings>(); 
        
               s << x; 
        
               out<<"\t\t\t\""<<p.name()<<"\":\""<<marshall.toBase64()<<"\",\n"; 
        
           }

This makes Qt6 builds unusable, except for testing purposes, I couldn't find the cause yet.

jlaunay · 2024-01-23T00:50:08Z

Thanks a lot for your work, master also builds with Qt 6.6.1 on archlinux (same problem with the Metric Trends chart).
QT_QPA_PLATFORM=wayland is now supported with the Qt 6 build and it runs perfectly on Sway.

amtriathlon · 2024-01-23T23:13:41Z

Main pending issue for me now when building with Qt6 is Metric Trends chart not being correctly saved.

Fixed by 4224fd1, solution was trivial, to find the cause, not so much :(

Related to #3983, see discussion there for the rationale.

andreasbuhr mentioned this issue Jul 28, 2021

some fixes #3982

Closed

liversedge added the QT6 Refactor Updating code to move to QT 6 label Jul 28, 2021

liversedge added this to the 3.7 milestone Jul 28, 2021

amtriathlon added a commit that referenced this issue Mar 1, 2024

Deprecate export to KML files

ecdfe0c

Related to #3983, see discussion there for the rationale.

Shadmeister mentioned this issue Mar 9, 2024

GoldenCheetah Linux KDE/Wayland and nVidia Graphics Cards Bug #4454

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port to Qt6 #3983

Port to Qt6 #3983

andreasbuhr commented Jul 26, 2021

liversedge commented Jul 28, 2021

andreasbuhr commented Jul 28, 2021

amtriathlon commented Jan 13, 2024 •

edited

liversedge commented Jan 13, 2024

liversedge commented Jan 13, 2024

amtriathlon commented Jan 13, 2024 •

edited

liversedge commented Jan 13, 2024

amtriathlon commented Jan 15, 2024

andreasbuhr commented Jan 15, 2024

amtriathlon commented Jan 15, 2024

andreasbuhr commented Jan 15, 2024

amtriathlon commented Jan 15, 2024 •

edited

liversedge commented Jan 16, 2024

amtriathlon commented Jan 16, 2024 •

edited

amtriathlon commented Jan 16, 2024 •

edited

amtriathlon commented Jan 16, 2024 •

edited

Joern-R commented Jan 17, 2024 via email

liversedge commented Jan 17, 2024

amtriathlon commented Jan 17, 2024

amtriathlon commented Jan 17, 2024 •

edited

liversedge commented Jan 17, 2024

amtriathlon commented Jan 18, 2024 •

edited

amtriathlon commented Jan 18, 2024

amtriathlon commented Jan 18, 2024 •

edited

jlaunay commented Jan 23, 2024

amtriathlon commented Jan 23, 2024

Port to Qt6 #3983

Port to Qt6 #3983

Comments

andreasbuhr commented Jul 26, 2021

liversedge commented Jul 28, 2021

andreasbuhr commented Jul 28, 2021

amtriathlon commented Jan 13, 2024 • edited

liversedge commented Jan 13, 2024

liversedge commented Jan 13, 2024

amtriathlon commented Jan 13, 2024 • edited

liversedge commented Jan 13, 2024

amtriathlon commented Jan 15, 2024

andreasbuhr commented Jan 15, 2024

amtriathlon commented Jan 15, 2024

andreasbuhr commented Jan 15, 2024

amtriathlon commented Jan 15, 2024 • edited

liversedge commented Jan 16, 2024

amtriathlon commented Jan 16, 2024 • edited

amtriathlon commented Jan 16, 2024 • edited

amtriathlon commented Jan 16, 2024 • edited

Joern-R commented Jan 17, 2024 via email

liversedge commented Jan 17, 2024

amtriathlon commented Jan 17, 2024

amtriathlon commented Jan 17, 2024 • edited

liversedge commented Jan 17, 2024

amtriathlon commented Jan 18, 2024 • edited

amtriathlon commented Jan 18, 2024

amtriathlon commented Jan 18, 2024 • edited

jlaunay commented Jan 23, 2024

amtriathlon commented Jan 23, 2024

amtriathlon commented Jan 13, 2024 •

edited

amtriathlon commented Jan 13, 2024 •

edited

amtriathlon commented Jan 15, 2024 •

edited

amtriathlon commented Jan 16, 2024 •

edited

amtriathlon commented Jan 16, 2024 •

edited

amtriathlon commented Jan 16, 2024 •

edited

amtriathlon commented Jan 17, 2024 •

edited

amtriathlon commented Jan 18, 2024 •

edited

amtriathlon commented Jan 18, 2024 •

edited