New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added and linted all the files for Agent-Assist App. #541
base: main
Are you sure you want to change the base?
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an incredibly large Pull Request.
Quite a few of these files probably shouldn't be checked into a Git Repository.
We have a Google Cloud Storage Bucket gs://github-repo/
for related files for Notebooks/Sample Apps in this repo. I can upload files for you.
Can you please go through the files and determine which of them are needed for the app to function? The others, like the pickle, JSON, txt, images should probably go in the bucket and be linked from the other files to prevent the repo from getting too large.
We have identified these files and folders that can be stored in cloud bucket: |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (1052)
Some files were automatically ignored 🙈These sample patterns would exclude them:
You should consider adding them to:
File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use To accept these unrecognized words as correct and update file exclusions, you could run the following commands... in a clone of the git@github.com:nitchandak/generative-ai.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/GoogleCloudPlatform/generative-ai/actions/runs/9097639310/attempts/1' Available 📚 dictionaries could cover words not in the 📘 dictionary
Consider adding them (in with:
extra_dictionaries:
cspell:python/src/python/python-lib.txt
cspell:aws/aws.txt
cspell:python/src/common/extra.txt
cspell:fullstack/dict/fullstack.txt
cspell:python/src/python/python.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Pattern suggestions ✂️ (45)You could add these patterns to
Errors (4)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. |
…ive-ai into pr/nitchandak/541
Please resolve spelling errors shown in this check https://github.com/GoogleCloudPlatform/generative-ai/actions/runs/9101630581/attempts/1#summary-25019286805 For items that aren't errors, you can follow the instructions to add them to the list of approved terms. |
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTING
Guide.CODEOWNERS
for the file(s).nox -s format
from the repository root to format).Fixes #<issue_number_goes_here> 🦕