Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed validation message when trying to submit incorrect secret #7356

Merged
merged 1 commit into from Apr 27, 2015

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Apr 27, 2015

I've been playing with secrets today as part of my other PR, and I got:

invalid value 'sourceSecret': must match regex [A-Za-z_][A-Za-z0-9_]*

But since secret is validated with IsDNS1123Subdomain it should return different message, this PR contains fix for that.

/cc @pmorie @smarterclayton

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@smarterclayton
Copy link
Contributor

LGTM

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2015
a-robinson added a commit that referenced this pull request Apr 27, 2015
Fixed validation message when trying to submit incorrect secret
@a-robinson a-robinson merged commit 3102856 into kubernetes:master Apr 27, 2015
@soltysh soltysh deleted the fix_secret_validation branch July 23, 2015 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants