Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recovery for anonymous roll outs #7407

Merged
merged 1 commit into from Apr 30, 2015

Conversation

brendandburns
Copy link
Contributor

@jlowdermilk @bgrant0607 @smarterclayton @deads2k @ghodss

Builds off of #7279 please only review the 2nd commit.

@bgrant0607
Copy link
Member

What is this PR trying to fix/change?

@brendandburns
Copy link
Contributor Author

Right now, if you cancel a ---image based rollout with a ctrl-c you can't restart it, since it will attempt to re-create the "next" controller and fail in that attempt.

If you use an "anonymous" roll out (that is one for which the second controller is automatically generated with a hashed name) it may not recover correctly, because it doesn't know the name of the previous "next" controller, so we add an annotation to the "old" controller to make the "next" controller discoverable.

Thanks

@j3ffml
Copy link
Contributor

j3ffml commented Apr 28, 2015

Looks good. Will take second look after #7279 is merged.

@smarterclayton
Copy link
Contributor

cc @ironcladlou

On Apr 28, 2015, at 1:36 AM, Jeff Lowdermilk notifications@github.com wrote:

Looks good. Will take second look after #7279 is merged.


Reply to this email directly or view it on GitHub.

@j3ffml
Copy link
Contributor

j3ffml commented Apr 28, 2015

needs rebase

@brendandburns
Copy link
Contributor Author

It's rebased and good to go (shippable is a flake, and I'm hitting it again)

@j3ffml
Copy link
Contributor

j3ffml commented Apr 29, 2015

lgtm

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2015
j3ffml added a commit that referenced this pull request Apr 30, 2015
Support recovery for anonymous roll outs
@j3ffml j3ffml merged commit 6f5e081 into kubernetes:master Apr 30, 2015
@brendandburns brendandburns deleted the recovery2 branch August 7, 2015 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants