Augment describe to search for matching things if it doesn't match the original resource. #7467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NamespaceParam(namespace).DefaultNamespace(). | ||
| ResourceTypeOrNameArgs(true, rsrc). | ||
| SingleResourceType(). | ||
| Do() |
There was a problem hiding this comment.
Would be nice if you could reuse the builder (to guard against bit rot) but it's not easy to do here I don't think.
There was a problem hiding this comment.
Acknowledged.
|
Fixes #5905. Glad to have it, but not in v1.0, I'll point out. |
…e original resource
|
@smarterclayton comments addressed, please take another look. @bgrant0607 mea culpa, I think this is important for the end user experience when using Closes #5905 |
|
LGTM once travis is green |
smarterclayton
added
the
lgtm
|
Actually, can you add a test for this code path to hack/test-cmd? |
smarterclayton
added a commit
that referenced
this pull request
May 1, 2015
Augment describe to search for matching things if it doesn't match the original resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smarterclayton @jlowdermilk @ghodss @bgrant0607