Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StringSet.HasAny #7509

Merged
merged 1 commit into from May 4, 2015
Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 29, 2015

HasAny is useful shorthand. We use it for determining whether any change is necessary: https://github.com/deads2k/origin/blob/deads-make-remove-user-predictable/pkg/cmd/experimental/policy/remove_user_from_project.go#L74

@derekwaynecarr Any objection to creating this in the base library?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@derekwaynecarr
Copy link
Member

No objection from me... I know I added Difference, so HasAny is useful. Add a test case.

@deads2k
Copy link
Contributor Author

deads2k commented Apr 29, 2015

unit test added.

@smarterclayton
Copy link
Contributor

LGTM

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2015
smarterclayton added a commit that referenced this pull request May 4, 2015
@smarterclayton smarterclayton merged commit c07896e into kubernetes:master May 4, 2015
@deads2k deads2k deleted the deads-has-any branch June 11, 2015 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants