Handle conversion of boolean query parameters with a value of "false" #7541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smarterclayton ptal |
| @@ -74,6 +74,8 @@ func convertStringSliceToBool(input *[]string, out *bool, s conversion.Scope) er | |||
| switch strings.ToLower((*input)[0]) { | |||
| case "true", "1": | |||
| *out = true | |||
| case "false", "0": | |||
| *out = false | |||
| default: | |||
| *out = true | |||
There was a problem hiding this comment.
Should probably omit the case "true", "1" now - this is confusing at first sight. Add a comment that only false and 0 resolve to false, all other non-zero length values are true.
csrwng
force-pushed
the
fix_bool_conversion
branch
3 times, most recently
from
3fd286f
to
a049ccb
Compare
csrwng
force-pushed
the
fix_bool_conversion
branch
from
a049ccb
to
f72ee1f
Compare
|
updated and added more tests |
|
LGTM, travis flake rerunning |
smarterclayton
added
the
lgtm
cjcullen
added a commit
that referenced
this pull request
Apr 30, 2015
Handle conversion of boolean query parameters with a value of "false"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.