Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Push .md5 and .sha1 files for every file we push to GCS #7602

Merged
merged 1 commit into from May 1, 2015
Merged

Build: Push .md5 and .sha1 files for every file we push to GCS #7602

merged 1 commit into from May 1, 2015

Conversation

zmerlynn
Copy link
Member

Also by pre-staging and pushing all at once, and by doing the ACL
modify in parallel, this shaves the push time down anyways, despite
the extra I/O.

@zmerlynn
Copy link
Member Author

cc @roberthbailey or someone to possibly test on OS X, too. (just make release; build/push-devel-build.sh)?

@roberthbailey roberthbailey self-assigned this May 1, 2015
@roberthbailey
Copy link
Contributor

The shell looks reasonable. @eparis - want to take a look as well?

@roberthbailey
Copy link
Contributor

push-devel-build.sh just hangs for me on my mac. Maybe I'm not being patient enough?

!!! Error in ./build/../build/common.sh:840
  'gsutil -q -m "${gcs_options[@]+${gcs_options[@]}}" cp -r "${GCS_STAGE}"/* ${gcs_destination}' exited with status 1
Call stack:
  1: ./build/../build/common.sh:840 kube::release::gcs::copy_release_artifacts(...)
  2: ./build/../build/common.sh:779 kube::release::gcs::release(...)
  3: ./build/push-devel-build.sh:34 main(...)
Exiting with status 1

@zmerlynn
Copy link
Member Author

zmerlynn commented May 1, 2015

It was mid-copy. Home DSL? I took the gsutil spam out a while ago or you might see intermediate progress.

@roberthbailey
Copy link
Contributor

Yeah, could be the home network. I'll try again from work today.

On Fri, May 1, 2015 at 7:57 AM, Zach Loafman notifications@github.com
wrote:

It was mid-copy. Home DSL? I took the gsutil spam out a while ago or you
might see intermediate progress.

—
Reply to this email directly or view it on GitHub
#7602 (comment)
.

@zmerlynn zmerlynn mentioned this pull request May 1, 2015
Merged
@roberthbailey
Copy link
Contributor

I noticed that this pushed to gs://kubernetes-releases-9f55a rather than using the longer hash that we use elsewhere (see #6615). Can you update this code path to use the longer hash as well?

@zmerlynn
Build: Push .md5 and .sha1 files for every file we push to GCS
d3dbaa0 
Also by pre-staging and pushing all at once, and by doing the ACL
modify in parallel, this shaves the push time down anyways, despite
the extra I/O.

Along the way: Updates to longer hashes ala kubernetes#6615
@zmerlynn
Copy link
Member Author

zmerlynn commented May 1, 2015

Done, PTAL

@roberthbailey
Copy link
Contributor

Testing one more time before merging...

@roberthbailey
Copy link
Contributor

Still waiting on travis but since this only changes shell script, the tests aren't going to cover it anyway.

@roberthbailey roberthbailey reopened this May 1, 2015
roberthbailey added a commit that referenced this pull request May 1, 2015
@roberthbailey
Merge pull request #7602 from zmerlynn/upload_hashes
3a118cb 
Build: Push .md5 and .sha1 files for every file we push to GCS
@roberthbailey roberthbailey merged commit 3a118cb into kubernetes:master May 1, 2015
zmerlynn added a commit to zmerlynn/kubernetes that referenced this pull request May 1, 2015
@zmerlynn
Also push .sha1 for devel builds
8600ae5 
And adds a .sha1 cache file to indicate what file was already pushed
to GCS, and how to force it if not, removing a few seconds off a
kube-up/push if you're just cycling.

With this and kubernetes#7602, all TAR_URLS will have a .sha1 as well.
@zmerlynn zmerlynn mentioned this pull request May 1, 2015
Merged
zmerlynn added a commit to zmerlynn/kubernetes that referenced this pull request May 5, 2015
@zmerlynn
Also push .sha1 for devel builds
0c107e4 
And adds a .sha1 cache file to indicate what file was already pushed
to GCS, and how to force it if not, removing a few seconds off a
kube-up/push if you're just cycling.

With this and kubernetes#7602, all TAR_URLS will have a .sha1 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmerlynn @roberthbailey @googlebot