Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose: Create objects in a generic way #7699

Merged
merged 1 commit into from May 4, 2015
Merged

expose: Create objects in a generic way #7699

merged 1 commit into from May 4, 2015

Conversation

0xmichalis
Copy link
Contributor

@brendandburns
Copy link
Contributor

LGTM.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2015
@smarterclayton
Copy link
Contributor

Michail can you explain why you need this (so the change is documented here)?

@0xmichalis
Copy link
Contributor Author

Well, since the ability to expose more kinds of resources than just services is already in place (--generator flag) it's only natural for this change to happen. With this merged, it'll be easy for someone to register a new resource generator and use expose to generate such resources eg. we want to generate routes from services: openshift/origin#2045

@smarterclayton
Copy link
Contributor

Merging

smarterclayton added a commit that referenced this pull request May 4, 2015
expose: Create objects in a generic way
@smarterclayton smarterclayton merged commit 82b9397 into kubernetes:master May 4, 2015
@0xmichalis 0xmichalis deleted the make-expose-generic branch May 4, 2015 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants