Inject mounter into volume plugins #7702
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
@vmarmol PTAL |
| @@ -238,6 +230,7 @@ func (ed *emptyDir) TearDownAt(dir string) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| glog.Infof("TearDownAt: %v medium: %v isMnt: %v", dir, medium, isMnt) | |||
|
LGTM, just the one nit. |
|
@vmarmol Fixed |
|
LGTM |
Inject mounter into volume plugins
| @@ -68,9 +68,9 @@ func (plugin *awsElasticBlockStorePlugin) GetAccessModes() []api.AccessModeType | |||
| } | |||
| } | |||
|
|
|||
| func (plugin *awsElasticBlockStorePlugin) NewBuilder(spec *volume.Spec, podRef *api.ObjectReference, _ volume.VolumeOptions) (volume.Builder, error) { | |||
| func (plugin *awsElasticBlockStorePlugin) NewBuilder(spec *volume.Spec, podRef *api.ObjectReference, _ volume.VolumeOptions, mounter mount.Interface) (volume.Builder, error) { | |||
There was a problem hiding this comment.
At this point there is almost no reason for newBuilderInternal() in most volumes. We should flatten those and tets through NewBuilder.
There was a problem hiding this comment.
Good point
On Tue, May 5, 2015 at 3:59 PM, Tim Hockin notifications@github.com wrote:
In pkg/volume/aws_ebs/aws_ebs.go
#7702 (comment)
:@@ -68,9 +68,9 @@ func (plugin *awsElasticBlockStorePlugin) GetAccessModes() []api.AccessModeType
}
}-func (plugin *awsElasticBlockStorePlugin) NewBuilder(spec *volume.Spec, podRef *api.ObjectReference, _ volume.VolumeOptions) (volume.Builder, error) {
+func (plugin *awsElasticBlockStorePlugin) NewBuilder(spec *volume.Spec, podRef *api.ObjectReference, _ volume.VolumeOptions, mounter mount.Interface) (volume.Builder, error) {At this point there is almost no reason for newBuilderInternal() in most
volumes. We should flatten those and tets through NewBuilder.—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/7702/files#r29706457
.
Split out from #6936; inject mounter into volume plugins