fix DeepCopy to properly support runtime.EmbeddedObject #7769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
smarterclayton
added
the
lgtm
smarterclayton
added a commit
that referenced
this pull request
May 5, 2015
fix DeepCopy to properly support runtime.EmbeddedObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeepCopy was failing on
runtime.EmbeddedObjectdue toSee the new unit test for a simple scenario.
This registers our types with gob at the same time that we're registering them with the scheme. The
gobNamereads a little bit weird, but I've added a comment and linked to the go source that describes the problem (go reflection is hard).@smarterclayton This is addresses one of the problems in the rebase.