Fix command field PodExecOptions #7773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is happening on versioned resources. However, the resources are not yet exposed by the client commands and are not being used yet. @smarterclayton PTAL |
|
LGTM. @bgrant0607 - the initial implementation of the new endpoint params was broken, this corrects it. No consumers should be affected |
|
Ok. As long as you're touching this, please clarify the description text. Command is an argv array? Does it execute in a shell? |
Change the command field to an array of strings.
|
@bgrant0607 - thx. Updated description. |
|
LGTM |
bgrant0607
added
the
lgtm
|
(Temp assigning Brian until Travis says it's OK—will merge then.) |
|
Travis green; merging. |
mbforbes
added a commit
that referenced
this pull request
May 5, 2015
Fix command field PodExecOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the command field to an array of strings.