Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose: Load input object for increased safety #7774

Merged
merged 1 commit into from May 11, 2015
Merged

expose: Load input object for increased safety #7774

merged 1 commit into from May 11, 2015

Conversation

0xmichalis
Copy link
Contributor

@smarterclayton
Copy link
Contributor

Can we add a simple test case to this to? Thanks for making these changes.

@smarterclayton
Copy link
Contributor

Is the travis failure related or a flake?

I0505 16:35:33.298210   37517 replication_controller.go:329] Replication Controller has been deleted default/frontend
FAIL!
Get rc {{range.items}}{{.id}}:{{end}}
  Expected: 
  Got:      redis-slave:
579 ./hack/test-cmd.sh

@smarterclayton
Copy link
Contributor

--- FAIL: TestRunExposeService (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x4a5db1]
goroutine 27 [running]:
testing.func·006()
    /usr/local/go/src/testing/testing.go:441 +0x249
github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd.RunExpose(0xc20805ff80, 0x7f901cc92230, 0xc208204770, 0xc208134ea0, 0xc2081e2b00, 0x2, 0x2, 0x0, 0x0)
    github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd/_test/_obj_test/expose.go:113 +0x751
github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd.func·012(0xc208134ea0, 0xc2081e2b00, 0x2, 0x2)
    github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd/_test/_obj_test/expose.go:42 +0xbf
github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd.TestRunExposeService(0xc2081cd0e0)
    /home/travis/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd/expose_test.go:61 +0xa87
testing.tRunner(0xc2081cd0e0, 0x14b40f0)
    /usr/local/go/src/testing/testing.go:447 +0x134
created by testing.RunTests
    /usr/local/go/src/testing/testing.go:555 +0xd4e

@0xmichalis
Copy link
Contributor Author

Travis is green at last!:relaxed:

@0xmichalis
Copy link
Contributor Author

@smarterclayton can we merge this now?

@smarterclayton
Copy link
Contributor

LGTM

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2015
smarterclayton added a commit that referenced this pull request May 11, 2015
expose: Load input object for increased safety
@smarterclayton smarterclayton merged commit 2e3c40b into kubernetes:master May 11, 2015
@0xmichalis 0xmichalis deleted the load-object-for-more-safety branch May 11, 2015 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants