Service port names are required for multi-port #7786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable to me, but @derekwaynecarr you might have a bit more context (feel free to reassign if not). |
thockin
force-pushed
the
ports
branch
3 times, most recently
from
d81a615
to
db8d011
Compare
|
ping |
|
ping - please reassign if you don't want this one. It's a 5 minute review :) |
There is no provision for the first port to be unnamed. I think I initially allowed that, but then the Subset struct became a sorted struct, so the first-ness of the port got lost. If you have a Service with one named and one unnamed port, what happens is that the EndpointController fails to create Endpoints (validation error).
|
LGTM |
vishh
added a commit
that referenced
this pull request
May 11, 2015
Service port names are required for multi-port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no provision for the first port to be unnamed. I think I
initially allowed that, but then the Subset struct became a sorted
struct, so the first-ness of the port got lost. If you have a Service
with one named and one unnamed port, what happens is that the
EndpointController fails to create Endpoints (validation error).