Add spark example to Sample Notebook #1003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add notebook description for spark session
typo fix
NiloFreitas
reviewed
Mar 16, 2023
| " .appName(\"Spark Session for Bike Sharing Data\") \\\n", | ||
| " .getOrCreate()\n", | ||
| "\n", | ||
| "path=\"gs://kristin_serverless_pyspark/bikesharingdemand-train.csv\"\n", |
There was a problem hiding this comment.
Is this csv too big? If it is small is better to have it under a resources folder and not hardcode a GCS path that may not exist in the future
| "This notebook let users \n", | ||
| "* run a sample Spark Session with a sample CSV file\n", | ||
| "* verify if GCS buckets are properly mounted as a file system and\n", | ||
| "* execute Python files that are stored in mounted GCS buckets by !python and %run commands and\n" |
There was a problem hiding this comment.
Do we need to keep this part of the implementation? I mean the gcsfuse and running a python file from the notebook. I thought that you were going to create a separate example to demonstrate that, and keep this project running only PySpark
There was a problem hiding this comment.
@kristin-kim If you can address the review questions, we can try to get this merged.
shakeebshams
approved these changes
Dec 1, 2023
|
Closed as stale. Please re-open if I'm wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple spark example to existing sample Notebook of folder