Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tools/vm-migrator to allow multiple-subnets migration. #1044

Closed
wants to merge 29 commits into from
Closed

Updated tools/vm-migrator to allow multiple-subnets migration. #1044

wants to merge 29 commits into from

Conversation

fgka
Copy link

@fgka fgka commented Jun 30, 2023

Changes: allow multiple subnets to be migrated together.

There are also the following changes:

  • configuration moved from environment variables to a JSON file (example provided).
  • fixed the logging to properly set the level and send it to a log file (optional).
  • multiple edits on exception messages to indicate more precise what went wrong.
  • multiple debugging log messages added to trace the execution (for debugging purposes).
  • formatted the code using black.

Natalia Strelkova and others added 28 commits July 16, 2021 11:02
Initial commit: Terraform for creating backend access for serverless …
d2f4223 
…apps in a shared VPC
@skalolazka
style for variables
a8fc778
variables to variables.tf
e9b417a
README on modules usage
123d954
merge README
1aaa2fd
serverless_endpoint to module
086df5a
forgot a variable
b7b7feb
@cgrotz
Switched from name to reference for vpc network in order to solve con…
fe4e7f0 
…currency problems
@skalolazka
variable description fixed
8f41f7f
@skalolazka
Merge pull request #1 from cgrotz/main
3519749 
Switched from name to reference for vpc network in order to solve concurrency
self_link added in one missed place
b3b3c26
unused variable removed
288b284
link to documentation for the cloud_run_invoker variable
9756133
@skalolazka
Merge branch 'GoogleCloudPlatform:main' into main
62c502a
Merge remote-tracking branch 'upstream/main'
fbb25be
@skalolazka
Merge branch 'GoogleCloudPlatform:main' into main
a8af0a1
Merge branch 'main' of https://github.com/skalolazka/professional-ser…
d9863c3 
…vices
@fgka
Improved logging
a251ee7
@fgka
Merge pull request #4 from fgka/3-improve-logging
69822f6 
Improved logging
@fgka
Added sequential multiple-subnets support
30402dd
@fgka
Upgraded dependencies and changed Makefile
39fb6c2
@fgka
Moved sample json to root
89cd67f
@fgka
Minor bug on passing target_scopes back to the single_subnet
b99efd2
@fgka
Multi-subnet and multi-zone
8187272
@fgka
Merge pull request #9 from fgka/1-add-support-to-multiple-subnets
c733131 
1 add support to multiple subnets
@fgka
Formatted using black
4e271f2
@fgka
Updated documenation
561001c
@fgka
JSON blob formatting
45b29ec
@google-cla
Copy link

google-cla bot commented Jun 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines. label Jun 30, 2023
shakeebshams
shakeebshams reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@shakeebshams shakeebshams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please sign the CLA: https://cla.developers.google.com with the email of the current github account you are using

@agold-rh
Copy link
Contributor

Closed as stale. Please re-open if I'm wrong.

@agold-rh agold-rh closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakeebshams shakeebshams shakeebshams left review comments

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fgka @agold-rh @shakeebshams @skalolazka @cgrotz