Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1273

Merged
merged 2 commits into from May 15, 2024
Merged

Update README.md #1273

merged 2 commits into from May 15, 2024

Conversation

orenholl
Copy link
Contributor

@orenholl orenholl commented May 6, 2024

Pull Request Template

Please, go through these steps before you submit a PR.

  1. Make sure that your PR is not a duplicate.

  2. Before submitting the PR, review your changes:

    • Adjust the code to the existing style.
    • Add a set of unit tests for the changes and ensure they all pass.
    • Add accompanying README.md file with instructions on usage. See awesome-readme for good examples of high-quality READMEs.
    • Add a link to your contribution in the top-level README (alpha-order).
    • Add Apache 2.0 license headers with an up-to-date copyright date attributed to Google LLC.
    • Remove unnecessary LICENSE files. There's no need to include an additional license since all repository submissions are covered by the top-level Apache 2.0 license.
  3. After these steps, you're ready to open a pull request.

    • Give a descriptive title to your PR.
    • Provide a description of your changes.
    • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines. label May 6, 2024
Copy link

google-cla bot commented May 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@franklinWhaite
Copy link
Member

Except for the issue with the checks, LGTM

@agold-rh
Copy link
Contributor

/gcbrun

@agold-rh agold-rh merged commit 8e13add into GoogleCloudPlatform:main May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants