Honeycomb support #213
Honeycomb support #213
Conversation
|
Looks sweet! |
|
Some fun with getting the annotations in |
|
What do we need to do for deploying this? |
|
Needs some TLC to make mypy not fail spectacularly on upgrading to python 3.9. I don't want to rip out the types again, but I'm not yet sure what the problem is that it has with them. IIRC it's a runtime issue too, not just static analysis. |
|
Okay, looks like it may just require updating mypy |
TheLonelyGhost
force-pushed
the
honeycomb
branch
2 times, most recently
from
e90c51c
to
14c33f0
Compare
TheLonelyGhost
force-pushed
the
honeycomb
branch
from
14c33f0
to
b7824eb
Compare
TheLonelyGhost
requested review from
MaxVanDeursen and
a team
and removed request for
MaxVanDeursen
|
Upgrading mypy to >= v0.800 is what fixed the python 3.9 support. Now we're on v0.902 of it, so I hope python 3.10 doesn't introduce any unexpected problems like the last "minor" upgrade. |
- prawcore (2.0.0 -> 2.2.0) - websocket-client (1.0.1 -> 0.54.0) - slackclient (1.0.6 -> 1.3.2)
| @@ -1,13 +1,14 @@ | |||
| from datetime import datetime, timedelta | |||
|
|
|||
| from praw import Reddit | |||
| from praw.exceptions import RedditAPIException | |||
| # from praw.exceptions import RedditAPIException | |||
There was a problem hiding this comment.
Better not to comment code
There was a problem hiding this comment.
This is a throwaway script that's supposed to be modified in place depending on whatever we need -- if this is the only issue you have with the PR, then I would consider it good to go
There was a problem hiding this comment.
^^^ This.
Main reason I commented it out here instead of deleting is because some seemingly important try-except code was commented out later in the file, where it handles this particular exception. Rather than delete the commented code in its entirety, this file seems more like a living workspace just in case we need it. Might even be able to delete it if we rework it into one of the commands in the bot. 🤷
itsthejoker
dismissed
MaxVanDeursen’s stale review
Changes requested in file outside of scope
No description provided.