Allow https build.fhir.org links for ciUrl #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmckenzi
reviewed
Sep 13, 2022
|
It will not fail existing files that use http:, it allows for both. See the sample run at https://github.com/vadi2/JIRA-Spec-Artifacts/actions/runs/3046149892/jobs/4908596565 which demonstrates that both http and https work. |
lmckenzi
requested changes
Sep 13, 2022
|
I can't say I agree with that reasoning - as of today https: is the gold standard, and many IG's are using such links already. |
|
They shouldn't be able to use such links - the validation rules here should prevent that... Where are you seeing them? |
|
Quite a few in the repo...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow http as well as https build.fhir.org links for ciUrl attribute.
This reduces the number of false positives - before & after.