Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021 Media markdown #2705

Merged
merged 64 commits into from Dec 11, 2021
Merged

2021 Media markdown #2705

merged 64 commits into from Dec 11, 2021

Conversation

eeeps
Copy link
Contributor

@eeeps eeeps commented Dec 7, 2021

Markdownifying the google doc. WIP!

Makes progress on #2144

Staging: https://20211207t160821-dot-webalmanac.uk.r.appspot.com/en/2021/media

@tunetheweb tunetheweb added ASAP This issue is blocking progress writing Related to wording and content labels Dec 7, 2021
@tunetheweb
Copy link
Member

I've cleaned it up a little and staged it here: https://20211207t160821-dot-webalmanac.uk.r.appspot.com/en/2021/media (also added to the top comment). This doesn't auto update btw so need to reach out to update that occassionally.

@tunetheweb tunetheweb mentioned this pull request Dec 7, 2021
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not had a chance to go through this fully yet, but have some light feedback already so might as well get you started on those!

src/content/en/2021/media.md Show resolved Hide resolved
src/content/en/2021/media.md Outdated Show resolved Hide resolved
src/content/en/2021/media.md Show resolved Hide resolved
src/content/en/2021/media.md Outdated Show resolved Hide resolved
src/content/en/2021/media.md Outdated Show resolved Hide resolved
src/content/en/2021/media.md Outdated Show resolved Hide resolved
src/content/en/2021/media.md Outdated Show resolved Hide resolved
src/content/en/2021/media.md Outdated Show resolved Hide resolved
src/content/en/2021/media.md Outdated Show resolved Hide resolved
src/content/en/2021/media.md Outdated Show resolved Hide resolved
eeeps and others added 15 commits December 10, 2021 10:56
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
@eeeps
Copy link
Contributor Author

eeeps commented Dec 10, 2021

@tunetheweb oops, I missed the "30 hidden conversations" Github collapsed in the middle of your review!

Stole some time today to address all of the easy ones in the Images section. I'll try to make as much headway on the meatier things as I can over the next couple of days before I'm fully back on Monday.

I'll ping @dougsillars about your proposed changes to Video.

Thanks again @tunetheweb !! Extremely valuable feedback! Should we credit you as editor?

@eeeps
Copy link
Contributor Author

eeeps commented Dec 11, 2021

Ok, from my perspective, the final remaining tasks are:

  • decide whether to delete the "srcset resource densities" section. I'm in favor, but @tunetheweb if you think there's valuable insight here that's worth clarifying, I'm game to give it another go
  • possibly convert the video chart showing absolute counts to use percentages @dougsillars
  • possibly re-write the bit about default video aspect ratios @dougsillars
  • re-run the chart-PNG-generating Puppeteer script, and replace the updated charts in src/static/images/2021/media/

@tunetheweb
Copy link
Member

OK I've taken care of a couple of those things and left TODOs in place for the other two. We can pick them up in editing PR.

@dougsillars I had rewrite some of your queries and also had to change some of your preload text as it looks like there wasn't a switch from auto but more a move away from using preload at all.

I've updated the staging link at the top if you want to have a look.

I'm now going to merge this now, then do a quick copy edit later today or tomorrow and open the PR and then, if you accept that, we're done and can launch!

@tunetheweb tunetheweb merged commit 4c4d98e into HTTPArchive:main Dec 11, 2021
@eeeps eeeps deleted the media-markdown branch December 14, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP This issue is blocking progress writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants