Fix extra page header memory address #674
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code the
pextra *
pointer could be in[page_ptr, page_ptr+size]
interval, which is incorrect.There probably was a missing
+ size
in(char*)ptr + EXTRA_SIZE - sizeof(pextra)
.But as we have an extra size at the end :
#define EXTRA_SIZE (GC_PAGE_SIZE + (4<<10))
)Let's store that extra header always at the end.