Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra page header memory address #674

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gogoprog
Copy link

@gogoprog gogoprog commented Apr 5, 2024

With the current code the pextra * pointer could be in [page_ptr, page_ptr+size] interval, which is incorrect.

There probably was a missing + size in (char*)ptr + EXTRA_SIZE - sizeof(pextra).

But as we have an extra size at the end :
#define EXTRA_SIZE (GC_PAGE_SIZE + (4<<10)))

Let's store that extra header always at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants