fix: OPTIC-719: TypeError: e.target.className.includes is not a function #5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
bmartel
approved these changes
May 8, 2024
bmartel
reviewed
May 8, 2024
web/libs/datamanager/src/components/Common/Table/TableHead/TableHead.jsx
Outdated
Show resolved
Hide resolved
bmartel
reviewed
May 8, 2024
web/libs/datamanager/src/components/Common/TableOld/TableHead/TableHead.jsx
Outdated
Show resolved
Hide resolved
hlomzik
reviewed
May 8, 2024
web/libs/datamanager/src/components/Common/Table/TableHead/TableHead.jsx
Outdated
Show resolved
Hide resolved
hlomzik
approved these changes
May 8, 2024
luarmr
force-pushed
the
fb-optic-719/typeerror
branch
from
eaea1a1
to
1d016c4
Compare
luarmr
force-pushed
the
fb-optic-719/typeerror
branch
2 times, most recently
from
7f3532a
to
b0dc7c5
Compare
…leHead.jsx Co-authored-by: hlomzik <hlomzik@gmail.com>
luarmr
force-pushed
the
fb-optic-719/typeerror
branch
from
4385969
to
d14113c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error coming from Sentry
https://heartex.sentry.io/issues/5039994894/
There is no impact on the user.
This happens when a user drags and drops, for example, when the column header is an SVG. I confirm that the drag-and-drop feature continues to work well.
Also,
?wont work because in the case of failure is an image that is an svg and className is aSVGAnimatedStringobject. No need to pursue baseVal since we don't have the classNamehandle