Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bug in petab importer #636

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix minor bug in petab importer #636

wants to merge 2 commits into from

Conversation

arrjon
Copy link
Collaborator

@arrjon arrjon commented Apr 11, 2024

The Petab importer also generates an Amici model, which requires adapting parameter scales. However, a small bug occurred due to passing the entire dictionary to the rescale function instead of just the specific dictionary value. This resulted in failure during simulation.

@arrjon arrjon added the bug label Apr 11, 2024
@arrjon arrjon requested a review from stephanmg April 11, 2024 11:48
@arrjon arrjon self-assigned this Apr 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (6446a77) to head (d486ede).
Report is 236 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #636      +/-   ##
===========================================
+ Coverage    84.08%   84.32%   +0.23%     
===========================================
  Files           91      141      +50     
  Lines         5260     8535    +3275     
===========================================
+ Hits          4423     7197    +2774     
- Misses         837     1338     +501     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants