-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows 95/98/ME support to the GDI demo #534
base: master
Are you sure you want to change the base?
Conversation
|
||
HPEN pen = NULL; | ||
if (line_thickness == 1) { | ||
SetDCPenColor(dc, color); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this removal?
ExtTextOutW(dc, x, y, ETO_OPAQUE, NULL, wstr, wsize, NULL); | ||
} else { | ||
/* TODO: Convert from UTF-8 to the active code page */ | ||
ExtTextOutA(dc, x, y, ETO_OPAQUE, NULL, text, len, NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if you plan to work on this conversion any time soon.
Interesting. I am open to merge this as increasing platform compatibility is generally a good idea and the changes do not look harmful to me. Still I wonder what the motivation is as these old systems are super obsolete and I am having hard time imagining anyone targeting them to write new code for. Any insights?
Do you plan to work on it any time soon? Or shall we rather merge this and not wait?
Feel free to consult our wiki in case you missed it: https://github.com/Immediate-Mode-UI/Nuklear/wiki/Complete-font-guide
Could you please add comment(s) to the relevant part(s) of the source code describing how to disable this dependency? Thanks! |
Looks like there's a conflict |
This mostly works, with a few caveats:
nk_gdi_rect_multi_color
requires msimg32.dll which isn't always available. This can be trivially disabled if it's not needed.Screenshot: