Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement conversion of Uniform to GeneralQuadratureTable #49

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Implement conversion of Uniform to GeneralQuadratureTable #49

wants to merge 5 commits into from

Conversation

w1th0utnam3
Copy link
Member

Implements

  • UniformQuadratureTable::to_general(&self, num_elements)
  • GeneralQuadratureTable::with_data(self, data)

@w1th0utnam3
Copy link
Member Author

Not sure what happened with CI here, maybe you can manually re-run it @Andlon?

@Andlon
Copy link
Member

Andlon commented Nov 14, 2022

Not sure what happened with CI here, maybe you can manually re-run it @Andlon?

Hmm, somehow I can't see anything about the CI at all, not sure what's happened here...

Andlon
Andlon requested changes Nov 18, 2022
View reviewed changes
Copy link
Member

@Andlon Andlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks useful! Please see comments.

Some very basic tests would also be nice.

src/assembly/local/quadrature_table.rs Outdated Show resolved Hide resolved
src/assembly/local/quadrature_table.rs Outdated Show resolved Hide resolved
src/assembly/local/quadrature_table.rs Show resolved Hide resolved
Andlon
Andlon reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@Andlon Andlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I just still think that with_data_from_fn deserves a simple unit test.

@Andlon Andlon mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andlon Andlon Andlon requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@w1th0utnam3 @Andlon