Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daggerfall Proofreading Project, Part 1: String Files (Take Two) #2625

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Mentill
Copy link

@Mentill Mentill commented Mar 25, 2024

This contains ~200 corrections to spelling & grammar errors/typos to the string files (excluding internal_locations.csv), all done by hand.

The Internal_Locations.csv file was copied to the Text folder so it can override the misspelled names normally loaded directly from MAPS.BSA. I didn't go through all ~15k entries, but rather a representative sample since they're procedurally-generated.

Some changes were made to improve consistency. In particular:

  • the one message that refers to the Cart was changed to Wagon, to be consistent with every other message; the item name was left alone

  • the Pickpocket skill was renamed to Pickpocketing to match the strings, and for consistency with Backstabbing and Lockpicking

  • references to Critical Striking were changed to Critical Strike, as that's the skill's current name, which I feel sounds better despite being less-consistent with the other skill names

I wasn't sure how to edit the images in INVE00I0.IMG & INVE01I0.IMG, which contain the rendered 'Wagon' buttons for the inventory screen, or if it were allowable to include modified versions in DFU's loose texture folder. Otherwise, I would've changed every 'Wagon' reference to 'Cart', including that button. I left the Transport menu's 'Cart' button graphic unmodified for the same reason.

It was recommended that I split my project into parts submitted one at a time, so this first part is just the string files. Next will be the quests, of which I corrected typos in ~170 of them; if that's too many, I can split that, too.
I had improved the formatting of the books, but it seems another PR did a better job on that; I didn't proofread many of those, though.
Hopefully I did this all correctly this time, the file diffs all look good to me...

strings notes.txt

@@ -7198,7 +7198,7 @@ MonoBehaviour:
%ach for every
%clc level(s) of the caster.[/center]

Dimunization will last for %bdr
Diminution will last for %bdr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect diminutization was the intended word; Either way, that spell was not implemented so that text is currently unused
https://en.wiktionary.org/wiki/diminutize#English

@@ -12752,7 +12752,7 @@ MonoBehaviour:
m_Localized: 'Barbarians are warriors that hail from the harsh[/center]

lands
that fringe more civilized areas. They make excellent[/center]
that fringe more-civilized areas. They make excellent[/center]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English is not my native language, but I haven't seen a dash used in that context before or by looking around

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I perhaps use more hyphens than most writers, but I think it's justified in this case to show the two words are connected, so as to intuitively clarify that it shouldn't be misinterpreted as 'a greater number of civilized areas.' I dislike ambiguous syntax even if it's considered technically-correct English.

@@ -21957,10 +21957,10 @@ MonoBehaviour:
I want to give you directions %pcf?[/record]

Listen, I ain''t got time
for this. Why don''t you just kiss off, %pcf.[/record]
for this. Why don''t you just kiss off, %pcf?[/record]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a non-question, so I wouldn't use a question mark here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some research on this during editing, and it turns out English linguists haven't reached consensus on whether or not rhetorical questions should end with a question mark; one major school says 'yes', another says 'no.' I think they look better with question marks so I added them in cases where it looked 'right' to me.
I attempted to avoid adding question marks to indirect questions, however.

@@ -0,0 +1,15252 @@
Key,Value
Copy link
Collaborator

@petchema petchema Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file doesn't exist under this path on master branch, it can only be found under Assets/StreamingAssets/Text/Master Localization CSV Files

The Internal_Locations.csv file was copied to the Text folder so it can override the misspelled names normally loaded directly from MAPS.BSA.

I see... Well, is everyone okay with merging that change, @KABoissonneault, @ajrb,... ?

@petchema
Copy link
Collaborator

petchema commented Apr 3, 2024

I finished my first read of the patch, and it's obvious you spent a lot of time on those fixes, well done!

@Mentill
Copy link
Author

Mentill commented Apr 4, 2024

I finished my first read of the patch, and it's obvious you spent a lot of time on those fixes, well done!

Thanks! When I did a second pass through the main quests I found a few typos I'd missed the first time, so I probably only found 95% of the issues. I found a bunch of words that seemed wrong but upon research turned out to be nonstandard or archaic forms. I also left the underworld speech and sesquipedalian loquaciousness alone unless there was an obviously-unintended typo. Many of the 'issues' that remain are borderline cases, aesthetic preference, or unusual phrasing that's just not wrong/problematic enough to justify changing the style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants