Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH DEBT] Crayfish controllers hardcode parameters #2169

Open
jordandukart opened this issue Sep 14, 2022 · 2 comments
Open

[TECH DEBT] Crayfish controllers hardcode parameters #2169

jordandukart opened this issue Sep 14, 2022 · 2 comments
Assignees
@whikloj
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)

Comments

@jordandukart
Copy link
Member

Overview of feature request
Crayfish controllers hardcode parameters on commands examples: https://github.com/Islandora/Crayfish/blob/0a4e8d2b546f47f33c1a22f1a1ed1a3293e2f838/Houdini/src/Controller/HoudiniController.php#L121-125 and https://github.com/Islandora/Crayfish/blob/0a4e8d2b546f47f33c1a22f1a1ed1a3293e2f838/Homarus/src/Controller/HomarusController.php#L117.

Moving this to be completely controlled by the header allows greater flexibility.

What kind of user is the feature intended for?
Developer

What inspired the request?
https://github.com/Islandora/Crayfish/pull/162/files

What existing behavior do you want changed?
Hardcoding parameters to commands is inflexible.
@jordandukart jordandukart added the Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’) label Sep 14, 2022
@whikloj
Copy link
Member

whikloj commented Sep 14, 2022

This makes sense. But then so does Islandora/Crayfish#133

@whikloj whikloj self-assigned this Sep 21, 2022
@whikloj
Copy link
Member

whikloj commented Sep 21, 2022

Looking in to this, I'm wondering about the Houdini example. That one is modifying the STDIN argument for ImageMagick from - to pid:-[0].

We don't pass in this type of information for other microservices, so I am wondering if we want to start now?

The Homarus one is fine with me though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whikloj whikloj

Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordandukart @whikloj